pinctrl/at91: Don't provide a default trigger type
authorMarc Zyngier <marc.zyngier@arm.com>
Tue, 6 Sep 2016 13:58:15 +0000 (14:58 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 12 Sep 2016 12:17:02 +0000 (14:17 +0200)
at91 used to set a default trigger type for GPIO interrupts in
order to cope with the old board files. These days are long gone,
and it all gets probed through DT.

Andras Szemzo reported that the Ethernet device on his board was
bailing to be probed, due to a conflict in interrupt trigger.
Surely enough, this is due to this default trigger still being
present, and turning this into a IRQ_TYPE_NONE fixes the issue.

Reported-by: Andras Szemzo <szemzo.andras@gmail.com>
Tested-by: Andras Szemzo <szemzo.andras@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-at91.c

index 80daead..9f09041 100644 (file)
@@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
                                   &gpio_irqchip,
                                   0,
                                   handle_edge_irq,
-                                  IRQ_TYPE_EDGE_BOTH);
+                                  IRQ_TYPE_NONE);
        if (ret) {
                dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
                        at91_gpio->pioc_idx);