svcrpc: move some initialization to common code
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 20 Nov 2015 20:45:35 +0000 (15:45 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 24 Nov 2015 17:39:16 +0000 (10:39 -0700)
Minor cleanup, no change in behavior.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/svcauth.c
net/sunrpc/svcauth_unix.c

index 79c0f34..69841db 100644 (file)
@@ -55,6 +55,7 @@ svc_authenticate(struct svc_rqst *rqstp, __be32 *authp)
        spin_unlock(&authtab_lock);
 
        rqstp->rq_auth_slack = 0;
+       init_svc_cred(&rqstp->rq_cred);
 
        rqstp->rq_authop = aops;
        return aops->accept(rqstp, authp);
@@ -63,6 +64,7 @@ EXPORT_SYMBOL_GPL(svc_authenticate);
 
 int svc_set_client(struct svc_rqst *rqstp)
 {
+       rqstp->rq_client = NULL;
        return rqstp->rq_authop->set_client(rqstp);
 }
 EXPORT_SYMBOL_GPL(svc_set_client);
index 621ca7b..dfacdc9 100644 (file)
@@ -728,10 +728,6 @@ svcauth_null_accept(struct svc_rqst *rqstp, __be32 *authp)
        struct kvec     *resv = &rqstp->rq_res.head[0];
        struct svc_cred *cred = &rqstp->rq_cred;
 
-       cred->cr_group_info = NULL;
-       cred->cr_principal = NULL;
-       rqstp->rq_client = NULL;
-
        if (argv->iov_len < 3*4)
                return SVC_GARBAGE;
 
@@ -794,10 +790,6 @@ svcauth_unix_accept(struct svc_rqst *rqstp, __be32 *authp)
        u32             slen, i;
        int             len   = argv->iov_len;
 
-       cred->cr_group_info = NULL;
-       cred->cr_principal = NULL;
-       rqstp->rq_client = NULL;
-
        if ((len -= 3*4) < 0)
                return SVC_GARBAGE;