mfd: omap-usb-tll: Convert to devm_ioremap_resource()
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 9 Apr 2013 10:46:37 +0000 (16:16 +0530)
committerSamuel Ortiz <sameo@linux.intel.com>
Tue, 9 Apr 2013 13:01:31 +0000 (15:01 +0200)
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/omap-usb-tll.c

index 8f4d5a1..e59ac4c 100644 (file)
@@ -226,12 +226,9 @@ static int usbtll_omap_probe(struct platform_device *pdev)
        }
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       tll->base = devm_request_and_ioremap(dev, res);
-       if (!tll->base) {
-               ret = -EADDRNOTAVAIL;
-               dev_err(dev, "Resource request/ioremap failed:%d\n", ret);
-               return ret;
-       }
+       tll->base = devm_ioremap_resource(dev, res);
+       if (IS_ERR(tll->base))
+               return PTR_ERR(tll->base);
 
        platform_set_drvdata(pdev, tll);
        pm_runtime_enable(dev);