staging/comedi: Use && instead of & for logical comparision
authorPeter Huewe <peterhuewe@gmx.de>
Thu, 14 Feb 2013 21:27:06 +0000 (22:27 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Feb 2013 18:20:14 +0000 (10:20 -0800)
sparse complains that:
drivers/staging/comedi/drivers/adl_pci9118.c:813 pci9118_calc_divisors()
warn: maybe use && instead of &

usessh is used as a boolean flag (0 and 1) and is compared to a boolean
value so we should use && here.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/adl_pci9118.c

index ef4dbe5..4dbac74 100644 (file)
@@ -810,7 +810,7 @@ static void pci9118_calc_divisors(char mode, struct comedi_device *dev,
                *tim2 = *div1 * devpriv->i8254_osc_base;
                                                        /* real convert timer */
 
-               if (usessh & (chnsshfront == 0))        /* use BSSH signal */
+               if (usessh && (chnsshfront == 0))       /* use BSSH signal */
                        if (*div2 < (chans + 2))
                                *div2 = chans + 2;