i8k: Return -ENODATA for invalid temperature
authorPali Rohár <pali.rohar@gmail.com>
Mon, 12 Jan 2015 13:31:59 +0000 (14:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Jan 2015 17:17:58 +0000 (09:17 -0800)
Guenter Roeck suggested to return -ENODATA instead -ERANGE or -EINVAL when BIOS
reports invalid temperature value.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/i8k.c

index afcc9fe..1854fab 100644 (file)
@@ -331,7 +331,7 @@ static int i8k_get_temp(int sensor)
                prev[sensor] = temp;
        }
        if (temp > I8K_MAX_TEMP)
-               return -ERANGE;
+               return -ENODATA;
 #endif
 
        return temp;
@@ -533,8 +533,6 @@ static ssize_t i8k_hwmon_show_temp(struct device *dev,
        int temp;
 
        temp = i8k_get_temp(index);
-       if (temp == -ERANGE)
-               return -EINVAL;
        if (temp < 0)
                return temp;
        return sprintf(buf, "%d\n", temp * 1000);