brcmfmac: remove unused iswl variable.
authorHante Meuleman <meuleman@broadcom.com>
Mon, 22 Oct 2012 17:36:15 +0000 (10:36 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 29 Oct 2012 19:28:17 +0000 (15:28 -0400)
Variable iswl always gets initialised to the same and support for
this var is not needed.

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/brcm80211/brcmfmac/dhd.h
drivers/net/wireless/brcm80211/brcmfmac/dhd_cdc.c
drivers/net/wireless/brcm80211/brcmfmac/dhd_linux.c
drivers/net/wireless/brcm80211/brcmfmac/dhd_proto.h

index a73da9d..c915d33 100644 (file)
@@ -629,7 +629,6 @@ struct brcmf_pub {
        u8 wme_dp;              /* wme discard priority */
 
        /* Dongle media info */
-       bool iswl;              /* Dongle-resident driver is wl */
        unsigned long drv_version;      /* Version of dongle-resident driver */
        u8 mac[ETH_ALEN];               /* MAC address obtained from dongle */
 
index a5c15ca..b07a438 100644 (file)
@@ -481,9 +481,6 @@ int brcmf_proto_init(struct brcmf_pub *drvr)
 
        ret = brcmf_c_preinit_dcmds(drvr);
 
-       /* Always assumes wl for now */
-       drvr->iswl = true;
-
        return ret;
 }
 
index 189c5be..5f91fae 100644 (file)
@@ -619,12 +619,9 @@ static int brcmf_ethtool(struct brcmf_pub *drvr, void __user *uaddr)
                        brcmf_dbg(ERROR, "dongle is not up\n");
                        return -ENODEV;
                }
-
                /* finally, report dongle driver type */
-               else if (drvr->iswl)
-                       sprintf(info.driver, "wl");
                else
-                       sprintf(info.driver, "xx");
+                       sprintf(info.driver, "wl");
 
                sprintf(info.version, "%lu", drvr->drv_version);
                if (copy_to_user(uaddr, &info, sizeof(info)))
@@ -734,11 +731,6 @@ s32 brcmf_exec_dcmd(struct net_device *ndev, u32 cmd, void *arg, u32 len)
                goto done;
        }
 
-       if (!drvr->iswl) {
-               err = -EIO;
-               goto done;
-       }
-
        /*
         * Intercept BRCMF_C_SET_KEY CMD - serialize M4 send and
         * set key CMD to prevent M4 encryption.
index 6bc4425..f3e72de 100644 (file)
@@ -28,7 +28,7 @@ extern int brcmf_proto_attach(struct brcmf_pub *drvr);
 extern void brcmf_proto_detach(struct brcmf_pub *drvr);
 
 /* Initialize protocol: sync w/dongle state.
- * Sets dongle media info (iswl, drv_version, mac address).
+ * Sets dongle media info (drv_version, mac address).
  */
 extern int brcmf_proto_init(struct brcmf_pub *drvr);