ALSA: emu10k1: Delete an unnecessary check before the function call "kfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 3 Jan 2015 16:06:04 +0000 (17:06 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sun, 4 Jan 2015 14:12:08 +0000 (15:12 +0100)
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/emu10k1/p16v.c

index b672755..3c60b43 100644 (file)
@@ -166,11 +166,8 @@ static struct snd_pcm_hardware snd_p16v_capture_hw = {
 static void snd_p16v_pcm_free_substream(struct snd_pcm_runtime *runtime)
 {
        struct snd_emu10k1_pcm *epcm = runtime->private_data;
-  
-       if (epcm) {
-               /* dev_dbg(emu->card->dev, "epcm free: %p\n", epcm); */
-               kfree(epcm);
-       }
+
+       kfree(epcm);
 }
 
 /* open_playback callback */