V4L/DVB: ov7670: Always rewrite clkrc when setting format
authorJonathan Corbet <corbet@lwn.net>
Thu, 18 Mar 2010 22:10:18 +0000 (19:10 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 18 May 2010 03:51:24 +0000 (00:51 -0300)
That makes frame rate configuration persistent.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/ov7670.c

index 2124330..82d37d9 100644 (file)
@@ -838,8 +838,12 @@ static int ov7670_s_fmt(struct v4l2_subdev *sd, struct v4l2_format *fmt)
         * the other parameters or the image looks poor.  If we're *not*
         * doing RGB565, we must not rewrite clkrc or the image looks
         * *really* poor.
+        *
+        * (Update) Now that we retain clkrc state, we should be able
+        * to write it unconditionally, and that will make the frame
+        * rate persistent too.
         */
-       if (fmt->fmt.pix.pixelformat == V4L2_PIX_FMT_RGB565 && ret == 0)
+       if (ret == 0)
                ret = ov7670_write(sd, REG_CLKRC, info->clkrc);
        return ret;
 }