dmaengine: idma64: convert idma64_hw_desc_fill() to return void
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 17 Nov 2015 11:37:09 +0000 (13:37 +0200)
committerVinod Koul <vinod.koul@intel.com>
Sat, 5 Dec 2015 08:24:28 +0000 (13:54 +0530)
Explicitly show in idma64_desc_fill() how we link the hardware
descriptors.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/idma64.c

index 97802be..b6c13f9 100644 (file)
@@ -231,7 +231,7 @@ static void idma64_vdesc_free(struct virt_dma_desc *vdesc)
        idma64_desc_free(idma64c, to_idma64_desc(vdesc));
 }
 
-static u64 idma64_hw_desc_fill(struct idma64_hw_desc *hw,
+static void idma64_hw_desc_fill(struct idma64_hw_desc *hw,
                struct dma_slave_config *config,
                enum dma_transfer_direction direction, u64 llp)
 {
@@ -268,7 +268,6 @@ static u64 idma64_hw_desc_fill(struct idma64_hw_desc *hw,
                     IDMA64C_CTLL_SRC_WIDTH(src_width);
 
        lli->llp = llp;
-       return hw->llp;
 }
 
 static void idma64_desc_fill(struct idma64_chan *idma64c,
@@ -283,7 +282,8 @@ static void idma64_desc_fill(struct idma64_chan *idma64c,
        /* Fill the hardware descriptors and link them to a list */
        do {
                hw = &desc->hw[--i];
-               llp = idma64_hw_desc_fill(hw, config, desc->direction, llp);
+               idma64_hw_desc_fill(hw, config, desc->direction, llp);
+               llp = hw->llp;
                desc->length += hw->len;
        } while (i);