ALSA: emux: Delete an unnecessary check before the function call "snd_sf_free"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 3 Jan 2015 17:28:21 +0000 (18:28 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sun, 4 Jan 2015 14:12:29 +0000 (15:12 +0100)
The snd_sf_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/synth/emux/emux.c

index 9352207..f27a1c8 100644 (file)
@@ -160,12 +160,8 @@ int snd_emux_free(struct snd_emux *emu)
        snd_emux_detach_seq_oss(emu);
 #endif
        snd_emux_detach_seq(emu);
-
        snd_emux_delete_hwdep(emu);
-
-       if (emu->sflist)
-               snd_sf_free(emu->sflist);
-
+       snd_sf_free(emu->sflist);
        kfree(emu->voices);
        kfree(emu->name);
        kfree(emu);