OMAPDSS: remove extra out == NULL checks
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 4 Nov 2015 15:10:58 +0000 (17:10 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 29 Dec 2015 09:06:29 +0000 (11:06 +0200)
All the output drivers check for 'out' being NULL, but it can never be
NULL. Remove the check.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/video/fbdev/omap2/dss/dpi.c
drivers/video/fbdev/omap2/dss/dsi.c
drivers/video/fbdev/omap2/dss/hdmi4.c
drivers/video/fbdev/omap2/dss/hdmi5.c
drivers/video/fbdev/omap2/dss/rfbi.c
drivers/video/fbdev/omap2/dss/sdi.c
drivers/video/fbdev/omap2/dss/venc.c

index fb45b64..7953e6a 100644 (file)
@@ -395,7 +395,7 @@ static int dpi_display_enable(struct omap_dss_device *dssdev)
                goto err_no_reg;
        }
 
-       if (out == NULL || out->manager == NULL) {
+       if (out->manager == NULL) {
                DSSERR("failed to enable display: no output/manager\n");
                r = -ENODEV;
                goto err_no_out_mgr;
index b3606de..59065e1 100644 (file)
@@ -3833,7 +3833,7 @@ static int dsi_enable_video_output(struct omap_dss_device *dssdev, int channel)
        u16 word_count;
        int r;
 
-       if (out == NULL || out->manager == NULL) {
+       if (out->manager == NULL) {
                DSSERR("failed to enable display: no output/manager\n");
                return -ENODEV;
        }
index 94c8d55..7103c65 100644 (file)
@@ -343,7 +343,7 @@ static int hdmi_display_enable(struct omap_dss_device *dssdev)
 
        mutex_lock(&hdmi.lock);
 
-       if (out == NULL || out->manager == NULL) {
+       if (out->manager == NULL) {
                DSSERR("failed to enable display: no output/manager\n");
                r = -ENODEV;
                goto err0;
index b59ba79..a955a2c 100644 (file)
@@ -373,7 +373,7 @@ static int hdmi_display_enable(struct omap_dss_device *dssdev)
 
        mutex_lock(&hdmi.lock);
 
-       if (out == NULL || out->manager == NULL) {
+       if (out->manager == NULL) {
                DSSERR("failed to enable display: no output/manager\n");
                r = -ENODEV;
                goto err0;
index 1525a49..aea6a1d 100644 (file)
@@ -880,7 +880,7 @@ static int rfbi_display_enable(struct omap_dss_device *dssdev)
        struct omap_dss_device *out = &rfbi.output;
        int r;
 
-       if (out == NULL || out->manager == NULL) {
+       if (out->manager == NULL) {
                DSSERR("failed to enable display: no output/manager\n");
                return -ENODEV;
        }
index 5843580..d747cc6 100644 (file)
@@ -136,7 +136,7 @@ static int sdi_display_enable(struct omap_dss_device *dssdev)
        unsigned long pck;
        int r;
 
-       if (out == NULL || out->manager == NULL) {
+       if (out->manager == NULL) {
                DSSERR("failed to enable display: no output/manager\n");
                return -ENODEV;
        }
index 99ca268..c9260a4 100644 (file)
@@ -503,7 +503,7 @@ static int venc_display_enable(struct omap_dss_device *dssdev)
 
        mutex_lock(&venc.venc_lock);
 
-       if (out == NULL || out->manager == NULL) {
+       if (out->manager == NULL) {
                DSSERR("Failed to enable display: no output/manager\n");
                r = -ENODEV;
                goto err0;