[media] lirc_imon: do not leave imon_probe() with mutex held
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Sat, 14 Nov 2015 18:17:56 +0000 (16:17 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 19 Nov 2015 13:29:28 +0000 (11:29 -0200)
Commit af8a819a2513 ("[media] lirc_imon: simplify error handling code")
lost mutex_unlock(&context->ctx_lock), so imon_probe() exits with
the context->ctx_lock mutex acquired.

The patch adds mutex_unlock(&context->ctx_lock) back.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: af8a819a2513 ("[media] lirc_imon: simplify error handling code")

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/staging/media/lirc/lirc_imon.c

index 534b810..ff1926c 100644 (file)
@@ -885,12 +885,14 @@ static int imon_probe(struct usb_interface *interface,
                vendor, product, ifnum, usbdev->bus->busnum, usbdev->devnum);
 
        /* Everything went fine. Just unlock and return retval (with is 0) */
+       mutex_unlock(&context->ctx_lock);
        goto driver_unlock;
 
 unregister_lirc:
        lirc_unregister_driver(driver->minor);
 
 free_tx_urb:
+       mutex_unlock(&context->ctx_lock);
        usb_free_urb(tx_urb);
 
 free_rx_urb: