target: Indicate success if writing 0 to pi_prot_type
authorAndy Grover <agrover@redhat.com>
Thu, 9 Jul 2015 16:56:47 +0000 (09:56 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 24 Jul 2015 06:39:59 +0000 (23:39 -0700)
See https://bugzilla.redhat.com/show_bug.cgi?id=1240687

Returning 0 from a configfs store function results in infinite retries.

Reported-by: Yanko Kaneti <yaneti@declera.com>
Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_configfs.c

index 0b0de36..cb09e69 100644 (file)
@@ -747,7 +747,7 @@ static ssize_t store_pi_prot_type(struct se_dev_attrib *da,
        if (!dev->transport->init_prot || !dev->transport->free_prot) {
                /* 0 is only allowed value for non-supporting backends */
                if (flag == 0)
-                       return 0;
+                       return count;
 
                pr_err("DIF protection not supported by backend: %s\n",
                       dev->transport->name);