pcie-gadget-spear: fix error return code in spear_pcie_gadget_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Fri, 31 May 2013 12:01:30 +0000 (20:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Jun 2013 21:23:32 +0000 (14:23 -0700)
Fix to return a negative error code in the clk_get_sys() and clk_enable()
error handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/spear13xx_pcie_gadget.c

index 84a8dab..4ba0ea3 100644 (file)
@@ -814,9 +814,11 @@ static int spear_pcie_gadget_probe(struct platform_device *pdev)
                clk = clk_get_sys("pcie1", NULL);
                if (IS_ERR(clk)) {
                        pr_err("%s:couldn't get clk for pcie1\n", __func__);
+                       status = PTR_ERR(clk);
                        goto err_irq;
                }
-               if (clk_enable(clk)) {
+               status = clk_enable(clk);
+               if (status) {
                        pr_err("%s:couldn't enable clk for pcie1\n", __func__);
                        goto err_irq;
                }
@@ -828,9 +830,11 @@ static int spear_pcie_gadget_probe(struct platform_device *pdev)
                clk = clk_get_sys("pcie2", NULL);
                if (IS_ERR(clk)) {
                        pr_err("%s:couldn't get clk for pcie2\n", __func__);
+                       status = PTR_ERR(clk);
                        goto err_irq;
                }
-               if (clk_enable(clk)) {
+               status = clk_enable(clk);
+               if (status) {
                        pr_err("%s:couldn't enable clk for pcie2\n", __func__);
                        goto err_irq;
                }