[media] drivers/media/media-device: move debug log before _devnode_unregister()
authorMax Kellermann <max@duempel.org>
Mon, 21 Mar 2016 13:30:33 +0000 (10:30 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sat, 7 May 2016 14:24:02 +0000 (11:24 -0300)
After media_devnode_unregister(), the struct media_device may be freed
already, and dereferencing it may crash.

Signed-off-by: Max Kellermann <max@duempel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/media-device.c

index 898a3cf..de92a6b 100644 (file)
@@ -801,9 +801,8 @@ void media_device_unregister(struct media_device *mdev)
        mutex_unlock(&mdev->graph_mutex);
 
        device_remove_file(&mdev->devnode.dev, &dev_attr_model);
+       dev_dbg(mdev->dev, "Media device unregistering\n");
        media_devnode_unregister(&mdev->devnode);
-
-       dev_dbg(mdev->dev, "Media device unregistered\n");
 }
 EXPORT_SYMBOL_GPL(media_device_unregister);