netfilter: nft_reject_inet: fix unintended fall-through in switch-statatement
authorPatrick McHardy <kaber@trash.net>
Wed, 12 Feb 2014 21:13:16 +0000 (21:13 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 14 Feb 2014 10:37:33 +0000 (11:37 +0100)
For IPv4 packets, we call both IPv4 and IPv6 reject.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nft_reject_inet.c

index 8a310f2..b718a52 100644 (file)
@@ -21,9 +21,9 @@ static void nft_reject_inet_eval(const struct nft_expr *expr,
 {
        switch (pkt->ops->pf) {
        case NFPROTO_IPV4:
-               nft_reject_ipv4_eval(expr, data, pkt);
+               return nft_reject_ipv4_eval(expr, data, pkt);
        case NFPROTO_IPV6:
-               nft_reject_ipv6_eval(expr, data, pkt);
+               return nft_reject_ipv6_eval(expr, data, pkt);
        }
 }