qeth: remove locks from sysfs _show
authorEugene Crosser <Eugene.Crosser@ru.ibm.com>
Mon, 18 May 2015 12:27:54 +0000 (14:27 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 18 May 2015 16:14:17 +0000 (12:14 -0400)
Locking is probably unnecessary in this case, and the rest of the
qeth sysfs code does not use locks in the *_show() functions.
Remove locks from the layer2 *_show() functions in which they where
accidentally introduced.

Signed-off-by: Eugene Crosser <Eugene.Crosser@ru.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_l2_sys.c

index 59e3aa5..6504d48 100644 (file)
@@ -23,8 +23,6 @@ static ssize_t qeth_bridge_port_role_state_show(struct device *dev,
        if (!card)
                return -EINVAL;
 
-       mutex_lock(&card->conf_mutex);
-
        if (qeth_card_hw_is_reachable(card) &&
                                        card->options.sbp.supported_funcs)
                rc = qeth_bridgeport_query_ports(card,
@@ -59,8 +57,6 @@ static ssize_t qeth_bridge_port_role_state_show(struct device *dev,
                        rc = sprintf(buf, "%s\n", word);
        }
 
-       mutex_unlock(&card->conf_mutex);
-
        return rc;
 }
 
@@ -123,12 +119,8 @@ static ssize_t qeth_bridgeport_hostnotification_show(struct device *dev,
        if (!card)
                return -EINVAL;
 
-       mutex_lock(&card->conf_mutex);
-
        enabled = card->options.sbp.hostnotification;
 
-       mutex_unlock(&card->conf_mutex);
-
        return sprintf(buf, "%d\n", enabled);
 }