USB: keyspan_pda: remove bogus disconnect test from dtr_rts
authorJohan Hovold <jhovold@gmail.com>
Thu, 21 Mar 2013 11:36:33 +0000 (12:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Mar 2013 20:44:18 +0000 (13:44 -0700)
Remove bogus (and unnecessary) test for serial->dev being NULL in
dtr_rts.

The device is never cleared, and disconnect is handled for dtr_rts in
usb-serial core anyway.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/keyspan_pda.c

index 3b17d5d..0d992ba 100644 (file)
@@ -595,12 +595,10 @@ static void keyspan_pda_dtr_rts(struct usb_serial_port *port, int on)
 {
        struct usb_serial *serial = port->serial;
 
-       if (serial->dev) {
-               if (on)
-                       keyspan_pda_set_modem_info(serial, (1<<7) | (1<< 2));
-               else
-                       keyspan_pda_set_modem_info(serial, 0);
-       }
+       if (on)
+               keyspan_pda_set_modem_info(serial, (1 << 7) | (1 << 2));
+       else
+               keyspan_pda_set_modem_info(serial, 0);
 }