video: fbdev: grvga.c: Fix for possible null pointer dereference
authorRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Tue, 20 May 2014 21:35:59 +0000 (23:35 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 23 May 2014 10:47:31 +0000 (13:47 +0300)
There is otherwise a risk of a possible null pointer dereference.

Was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/grvga.c

index c078701..2db5bb1 100644 (file)
@@ -514,9 +514,10 @@ free_fb:
 static int grvga_remove(struct platform_device *device)
 {
        struct fb_info *info = dev_get_drvdata(&device->dev);
-       struct grvga_par *par = info->par;
+       struct grvga_par *par;
 
        if (info) {
+               par = info->par;
                unregister_framebuffer(info);
                fb_dealloc_cmap(&info->cmap);