iommu/shmobile: Allocate archdata with kzalloc()

The archdata attached_list field isn't initialized, leading to random
crashes when accessed. Use kzalloc() to allocate the whole structure and
make sure all fields get initialized properly.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>

diff --git a/drivers/iommu/shmobile-iommu.c b/drivers/iommu/shmobile-iommu.c
index d572863..7a3b928 100644 (file)
--- a/drivers/iommu/shmobile-iommu.c
+++ b/drivers/iommu/shmobile-iommu.c
@@ -380,14 +380,13 @@ int ipmmu_iommu_init(struct shmobile_ipmmu *ipmmu)
                kmem_cache_destroy(l1cache);
                return -ENOMEM;
        }
-       archdata = kmalloc(sizeof(*archdata), GFP_KERNEL);
+       archdata = kzalloc(sizeof(*archdata), GFP_KERNEL);
        if (!archdata) {
                kmem_cache_destroy(l1cache);
                kmem_cache_destroy(l2cache);
                return -ENOMEM;
        }
        spin_lock_init(&archdata->attach_lock);
-       archdata->attached = NULL;
        archdata->ipmmu = ipmmu;
        ipmmu_archdata = archdata;
        bus_set_iommu(&platform_bus_type, &shmobile_iommu_ops);