ath9k: avoid using trinary operator w/ TX_STAT_INC
authorJohn W. Linville <linville@tuxdriver.com>
Thu, 14 Apr 2011 14:38:22 +0000 (10:38 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 14 Apr 2011 19:29:06 +0000 (15:29 -0400)
Otherwise, you get this:

  CC [M]  drivers/net/wireless/ath/ath9k/hif_usb.o
drivers/net/wireless/ath/ath9k/hif_usb.c: In function ‘ath9k_skb_queue_complete’:
drivers/net/wireless/ath/ath9k/hif_usb.c:230:12: error: expected expression before ‘do’
make[2]: *** [drivers/net/wireless/ath/ath9k/hif_usb.o] Error 1
make[1]: *** [drivers/net/wireless/ath/ath9k] Error 2
make: *** [drivers/net/wireless/ath/] Error 2

The TX_STAT_INC macro should probably be changed to accomodate such
usage, although using a trinary operator in place of an if-else seems
questionable to me anyway.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Acked-by: Sujith Manoharan <Sujith.Manoharan@Atheros.com>
drivers/net/wireless/ath/ath9k/hif_usb.c

index 3b0efab..48bcc1a 100644 (file)
@@ -227,7 +227,10 @@ static inline void ath9k_skb_queue_complete(struct hif_device_usb *hif_dev,
        while ((skb = __skb_dequeue(queue)) != NULL) {
                ath9k_htc_txcompletion_cb(hif_dev->htc_handle,
                                          skb, txok);
-               (txok) ? TX_STAT_INC(skb_success) : TX_STAT_INC(skb_failed);
+               if (txok)
+                       TX_STAT_INC(skb_success);
+               else
+                       TX_STAT_INC(skb_failed);
        }
 }