staging: wlags49_h2: fix up "205179d staging: wlags49_h2: strncpy, need checking...
authorChen Gang <gang.chen@asianux.com>
Thu, 16 May 2013 01:37:32 +0000 (09:37 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 May 2013 23:08:00 +0000 (16:08 -0700)
Type of 'probe_rsp->rawData[1]' is 'hcf_8' which is 'u8', it will
compare with 'int', so use min_t() to cast to 'u8' to avoid related
warning.

If use min(), it has '(void) (&_min1 == &_min2);', so if no type cast,
the compiler will report 'pointer types lacks a cast':

  drivers/staging/wlags49_h2/wl_main.c:3174:122: warning: comparison of distinct pointer types lacks a cast [enabled by default]

Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlags49_h2/wl_main.c

index 35d617d..4353561 100644 (file)
@@ -3171,7 +3171,8 @@ void wl_process_mailbox( struct wl_private *lp )
 
                                        memset( ssid, 0, sizeof( ssid ));
                                        strncpy( ssid, &probe_rsp->rawData[2],
-                                                min(probe_rsp->rawData[1],
+                                                min_t(u8,
+                                                       probe_rsp->rawData[1],
                                                        HCF_MAX_NAME_LEN - 1));
 
                                        DBG_TRACE( DbgInfo, "(%s) SSID        : %s\n",