iio: accel: sca3000: memory corruption in sca3000_read_first_n_hw_rb()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 8 Aug 2015 19:16:42 +0000 (22:16 +0300)
committerJonathan Cameron <jic23@kernel.org>
Sat, 3 Oct 2015 09:28:24 +0000 (10:28 +0100)
"num_read" is in byte units but we are write u16s so we end up write
twice as much as intended.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/accel/sca3000_ring.c

index 23685e7..bd2c69f 100644 (file)
@@ -116,7 +116,7 @@ static int sca3000_read_first_n_hw_rb(struct iio_buffer *r,
        if (ret)
                goto error_ret;
 
-       for (i = 0; i < num_read; i++)
+       for (i = 0; i < num_read / sizeof(u16); i++)
                *(((u16 *)rx) + i) = be16_to_cpup((__be16 *)rx + i);
 
        if (copy_to_user(buf, rx, num_read))