staging: lustre: obdecho: Use !x to check for kzalloc failure
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 20 Jun 2015 16:59:08 +0000 (18:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jul 2015 02:35:53 +0000 (19:35 -0700)
!x is more normal for kzalloc failure in the kernel.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
statement S1, S2;
@@

x = kzalloc(...);
if (
- x == NULL
+ !x
 ) S1 else S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/obdecho/echo_client.c

index 0222fd2..de6f795 100644 (file)
@@ -480,11 +480,11 @@ static int echo_alloc_memmd(struct echo_device *ed,
 
        LASSERT(*lsmp == NULL);
        *lsmp = kzalloc(lsm_size, GFP_NOFS);
-       if (*lsmp == NULL)
+       if (!*lsmp)
                return -ENOMEM;
 
        (*lsmp)->lsm_oinfo[0] = kzalloc(sizeof(struct lov_oinfo), GFP_NOFS);
-       if ((*lsmp)->lsm_oinfo[0] == NULL) {
+       if (!(*lsmp)->lsm_oinfo[0]) {
                kfree(*lsmp);
                return -ENOMEM;
        }
@@ -701,7 +701,7 @@ static struct lu_device *echo_device_alloc(const struct lu_env *env,
        int cleanup = 0;
 
        ed = kzalloc(sizeof(*ed), GFP_NOFS);
-       if (ed == NULL) {
+       if (!ed) {
                rc = -ENOMEM;
                goto out;
        }
@@ -1878,7 +1878,7 @@ echo_client_iocontrol(unsigned int cmd, struct obd_export *exp, int len,
                return rc;
 
        env = kzalloc(sizeof(*env), GFP_NOFS);
-       if (env == NULL)
+       if (!env)
                return -ENOMEM;
 
        rc = lu_env_init(env, LCT_DT_THREAD);
@@ -2049,7 +2049,7 @@ static int echo_client_setup(const struct lu_env *env,
        ec->ec_nstripes = 0;
 
        ocd = kzalloc(sizeof(*ocd), GFP_NOFS);
-       if (ocd == NULL) {
+       if (!ocd) {
                CERROR("Can't alloc ocd connecting to %s\n",
                       lustre_cfg_string(lcfg, 1));
                return -ENOMEM;