drm/rcar-du: Remove redundant calls to drm_connector_register_all()
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 17 Jun 2016 08:25:23 +0000 (09:25 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 21 Jun 2016 08:53:15 +0000 (10:53 +0200)
Up to now, the recommendation was for drivers to call drm_dev_register()
followed by drm_connector_register_all(). Now that
drm_connector_register() is safe against multiple invocations, we can
move drm_connector_register_all() to drm_dev_register() and not suffer
from any backwards compatibility issues with drivers not following the
more rigorous init ordering.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Tested-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1466151923-1572-8-git-send-email-chris@chris-wilson.co.uk
drivers/gpu/drm/rcar-du/rcar_du_drv.c

index 48ec4b6..36d3900 100644 (file)
@@ -278,7 +278,6 @@ static int rcar_du_remove(struct platform_device *pdev)
        struct rcar_du_device *rcdu = platform_get_drvdata(pdev);
        struct drm_device *ddev = rcdu->ddev;
 
-       drm_connector_unregister_all(ddev);
        drm_dev_unregister(ddev);
 
        if (rcdu->fbdev)
@@ -360,10 +359,6 @@ static int rcar_du_probe(struct platform_device *pdev)
        if (ret)
                goto error;
 
-       ret = drm_connector_register_all(ddev);
-       if (ret < 0)
-               goto error;
-
        DRM_INFO("Device %s probed\n", dev_name(&pdev->dev));
 
        return 0;