IB/hfi1: Remove anti-pattern in cdev init

Remove the usage of an anti-pattern goto in hfi1_cdev_init to improve
code readability.

Suggested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/staging/rdma/hfi1/device.c b/drivers/staging/rdma/hfi1/device.c
index c05c39d..6ee800f 100644 (file)
--- a/drivers/staging/rdma/hfi1/device.c
+++ b/drivers/staging/rdma/hfi1/device.c
@@ -82,13 +82,13 @@ int hfi1_cdev_init(int minor, const char *name,
        else
                device = device_create(class, NULL, dev, NULL, "%s", name);
 
-       if (!IS_ERR(device))
-               goto done;
-       ret = PTR_ERR(device);
-       device = NULL;
-       pr_err("Could not create device for minor %d, %s (err %d)\n",
-              minor, name, -ret);
-       cdev_del(cdev);
+       if (IS_ERR(device)) {
+               ret = PTR_ERR(device);
+               device = NULL;
+               pr_err("Could not create device for minor %d, %s (err %d)\n",
+                       minor, name, -ret);
+               cdev_del(cdev);
+       }
 done:
        *devp = device;
        return ret;