cpuidle: remove cpuidle_unregister_governor()
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 3 Oct 2013 15:56:55 +0000 (21:26 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 30 Oct 2013 00:21:24 +0000 (01:21 +0100)
cpuidle_unregister_governor() and cpuidle_replace_governor() aren't
used anymore and can be removed. They were used by cpufreq governors
earlier, but since the governors can't be compiled as modules any
more, these two functions aren't necessary.

Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Documentation/cpuidle/governor.txt
drivers/cpuidle/governor.c
include/linux/cpuidle.h

index 12c6bd5..d9020f5 100644 (file)
@@ -25,5 +25,4 @@ kernel configuration and platform will be selected by cpuidle.
 
 Interfaces:
 extern int cpuidle_register_governor(struct cpuidle_governor *gov);
-extern void cpuidle_unregister_governor(struct cpuidle_governor *gov);
 struct cpuidle_governor
index ea2f8e7..ca89412 100644 (file)
@@ -96,46 +96,3 @@ int cpuidle_register_governor(struct cpuidle_governor *gov)
 
        return ret;
 }
-
-/**
- * cpuidle_replace_governor - find a replacement governor
- * @exclude_rating: the rating that will be skipped while looking for
- * new governor.
- */
-static struct cpuidle_governor *cpuidle_replace_governor(int exclude_rating)
-{
-       struct cpuidle_governor *gov;
-       struct cpuidle_governor *ret_gov = NULL;
-       unsigned int max_rating = 0;
-
-       list_for_each_entry(gov, &cpuidle_governors, governor_list) {
-               if (gov->rating == exclude_rating)
-                       continue;
-               if (gov->rating > max_rating) {
-                       max_rating = gov->rating;
-                       ret_gov = gov;
-               }
-       }
-
-       return ret_gov;
-}
-
-/**
- * cpuidle_unregister_governor - unregisters a governor
- * @gov: the governor
- */
-void cpuidle_unregister_governor(struct cpuidle_governor *gov)
-{
-       if (!gov)
-               return;
-
-       mutex_lock(&cpuidle_lock);
-       if (gov == cpuidle_curr_governor) {
-               struct cpuidle_governor *new_gov;
-               new_gov = cpuidle_replace_governor(gov->rating);
-               cpuidle_switch_governor(new_gov);
-       }
-       list_del(&gov->governor_list);
-       mutex_unlock(&cpuidle_lock);
-}
-
index c082425..50fcbb0 100644 (file)
@@ -195,16 +195,10 @@ struct cpuidle_governor {
 };
 
 #ifdef CONFIG_CPU_IDLE
-
 extern int cpuidle_register_governor(struct cpuidle_governor *gov);
-extern void cpuidle_unregister_governor(struct cpuidle_governor *gov);
-
 #else
-
 static inline int cpuidle_register_governor(struct cpuidle_governor *gov)
 {return 0;}
-static inline void cpuidle_unregister_governor(struct cpuidle_governor *gov) { }
-
 #endif
 
 #ifdef CONFIG_ARCH_HAS_CPU_RELAX