msm: msm_fb: Move to using managed resources of kzalloc
authorPramod Gurav <pramod.gurav@smartplayin.com>
Tue, 26 Aug 2014 12:52:58 +0000 (18:22 +0530)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 26 Aug 2014 12:53:33 +0000 (15:53 +0300)
Move to managed verion of kzalloc. Also checks return for failure case
which was missing.

Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
CC: Tomi Valkeinen <tomi.valkeinen@ti.com>
CC: Stephen Boyd <sboyd@codeaurora.org>
CC: Jingoo Han <jg1.han@samsung.com>
CC: Rob Clark <robdclark@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/msm/msm_fb.c

index 4640188..2979d7e 100644 (file)
@@ -569,8 +569,13 @@ static int msmfb_probe(struct platform_device *pdev)
        mutex_init(&msmfb->panel_init_lock);
        init_waitqueue_head(&msmfb->frame_wq);
        INIT_WORK(&msmfb->resume_work, power_on_panel);
-       msmfb->black = kzalloc(msmfb->fb->var.bits_per_pixel*msmfb->xres,
-                              GFP_KERNEL);
+       msmfb->black = devm_kzalloc(&pdev->dev,
+                                   msmfb->fb->var.bits_per_pixel*msmfb->xres,
+                                   GFP_KERNEL);
+       if (!msmfb->black) {
+               ret = -ENOMEM;
+               goto error_register_framebuffer;
+       }
 
        printk(KERN_INFO "msmfb_probe() installing %d x %d panel\n",
               msmfb->xres, msmfb->yres);