staging: rts5208: Removed unnecessary return variable
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Sun, 21 Feb 2016 07:35:20 +0000 (13:05 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
This patch removes unnecessary return variables in switch statements.
This was done with Coccinelle:

@@ local idexpression ret; expression e1,e2; identifier label;
@@
switch ( ... ) {
case label : ...
- ret = e1;
- break;
+ return e1;
... default: ...
- ret = e2;
+ return e2;
... }
... when != ret
- return ret;
@@ type T; identifier x; @@
- T x;
... when != x

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rts5208/rtsx_scsi.c

index 60871f3..16284ca 100644 (file)
@@ -1931,20 +1931,15 @@ static int rw_mem_cmd_buf(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 
 static int suit_cmd(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 {
-       int result;
-
        switch (srb->cmnd[3]) {
        case INIT_BATCHCMD:
        case ADD_BATCHCMD:
        case SEND_BATCHCMD:
        case GET_BATCHRSP:
-               result = rw_mem_cmd_buf(srb, chip);
-               break;
+               return rw_mem_cmd_buf(srb, chip);
        default:
-               result = TRANSPORT_ERROR;
+               return TRANSPORT_ERROR;
        }
-
-       return result;
 }
 
 static int read_phy_register(struct scsi_cmnd *srb, struct rtsx_chip *chip)