From: Linus Torvalds Date: Fri, 27 May 2016 23:03:22 +0000 (-0700) Subject: make IS_ERR_VALUE() complain about non-pointer-sized arguments X-Git-Tag: v4.7-rc1~22 X-Git-Url: http://git.cascardo.info/?a=commitdiff_plain;ds=sidebyside;h=aa00edc1287a693eadc7bc67a3d73555d969b35d;p=cascardo%2Flinux.git make IS_ERR_VALUE() complain about non-pointer-sized arguments Now that the allmodconfig x86-64 build is clean wrt IS_ERR_VALUE() uses on integers, add a cast to a pointer and back to the argument, so that any new mis-uses of IS_ERR_VALUE() will cause warnings like warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] so that we don't re-introduce any bogus uses. Signed-off-by: Linus Torvalds --- diff --git a/include/linux/err.h b/include/linux/err.h index 56762ab41713..1e3558845e4c 100644 --- a/include/linux/err.h +++ b/include/linux/err.h @@ -18,7 +18,7 @@ #ifndef __ASSEMBLY__ -#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO) +#define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) static inline void * __must_check ERR_PTR(long error) {