From: Ankur Sharma <ankursharma@vmware.com>
Date: Sat, 11 Oct 2014 22:07:41 +0000 (-0700)
Subject: datapath-windows: Fix assertion in Netlink.c
X-Git-Tag: v2.4.0~1188
X-Git-Url: http://git.cascardo.info/?a=commitdiff_plain;h=2aca2188999d8986b664d4813b88c5c5823dc977;p=cascardo%2Fovs.git

datapath-windows: Fix assertion in Netlink.c

NlBufAt should be called with valid boundary limits (within head and tail).
Incorrect argument to NlBufAt was leading to assert hit, fixed the same.

Signed-off-by: Ankur Sharma <ankursharma@vmware.com>
Acked-by: Nithin Raju <nithin@vmware.com>
Tested-by: Nithin Raju <nithin@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
---

diff --git a/datapath-windows/ovsext/Netlink/Netlink.c b/datapath-windows/ovsext/Netlink/Netlink.c
index 7ec651f08..ae10a870d 100644
--- a/datapath-windows/ovsext/Netlink/Netlink.c
+++ b/datapath-windows/ovsext/Netlink/Netlink.c
@@ -51,7 +51,7 @@ NlFillOvsMsg(PNL_BUFFER nlBuf, UINT16 nlmsgType,
 
     /* To keep compiler happy for release build. */
     UNREFERENCED_PARAMETER(offset);
-    ASSERT(NlBufAt(nlBuf, offset, sizeof(struct _OVS_MESSAGE)) != 0);
+    ASSERT(NlBufAt(nlBuf, offset, 0) != 0);
 
     msgOut.nlMsg.nlmsgType = nlmsgType;
     msgOut.nlMsg.nlmsgFlags = nlmsgFlags;
@@ -88,7 +88,7 @@ NlFillNlHdr(PNL_BUFFER nlBuf, UINT16 nlmsgType,
 
     /* To keep compiler happy for release build. */
     UNREFERENCED_PARAMETER(offset);
-    ASSERT(NlBufAt(nlBuf, offset, sizeof(struct _NL_MSG_HDR)) != 0);
+    ASSERT(NlBufAt(nlBuf, offset, 0) != 0);
 
     msgOut.nlmsgType = nlmsgType;
     msgOut.nlmsgFlags = nlmsgFlags;