From d130ac9eb93052e6059ea6bf5fd636d415673388 Mon Sep 17 00:00:00 2001 From: Nithin Raju Date: Tue, 12 Apr 2016 10:12:26 -0700 Subject: [PATCH] datapath-windows: cleanup after NdisRegisterDeviceEx() The error handling code seems to be wrong. Signed-off-by: Nithin Raju Acked-by: Paul-Daniel Boca Signed-off-by: Ben Pfaff --- datapath-windows/ovsext/Datapath.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index 8c0c246a5..0a25af04d 100644 --- a/datapath-windows/ovsext/Datapath.c +++ b/datapath-windows/ovsext/Datapath.c @@ -459,17 +459,11 @@ OvsCreateDeviceObject(NDIS_HANDLE ovsExtDriverHandle) &deviceAttributes, &gOvsDeviceObject, &gOvsDeviceHandle); - if (status != NDIS_STATUS_SUCCESS) { - POVS_DEVICE_EXTENSION ovsExt = - (POVS_DEVICE_EXTENSION)NdisGetDeviceReservedExtension(gOvsDeviceObject); - ASSERT(gOvsDeviceObject != NULL); - ASSERT(gOvsDeviceHandle != NULL); - - if (ovsExt) { - ovsExt->numberOpenInstance = 0; - } - } else { + if (status == NDIS_STATUS_SUCCESS) { OvsRegisterSystemProvider((PVOID)gOvsDeviceObject); + } else { + OVS_LOG_ERROR("Failed to regiser pseudo device, error: 0x%08x", + status); } OVS_LOG_TRACE("DeviceObject: %p", gOvsDeviceObject); -- 2.20.1