pylint 1.4.3 version fixes
authorSimo Sorce <simo@redhat.com>
Thu, 7 May 2015 16:33:40 +0000 (12:33 -0400)
committerRob Crittenden <rcritten@redhat.com>
Thu, 7 May 2015 18:44:20 +0000 (14:44 -0400)
commit1bcc0d697dd37a9268641f0cbaa7e9e781552233
treef17e5fb0f9f0a1a922bcbd80ec798396c508f56d
parent93d4e52712767fe955f3a44a60a6c6f0f909423b
pylint 1.4.3 version fixes

Pylint 1.4.3 completely stopped recognizing the star-args condition.
In order to avoid pylint error with > 1.4.3 stop caring for star-args
and add cmdline option to ignore those errors completly so older pylint
versions are happy too.

Also fix type() vs isinstance() checks, isinstance is generally a more
correct approach to check for classes.

In some 'admin' files the type() -> isinstance() fix required to invert
the order in which ComplexList and MappingList are checked as the latter
is a subclass of ComplexList, so it needs to be checked first otherwise
the check for isinstance(option, ComplexList) matches for both and the
code stops functioning properly.

Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Rob Crittenden <rcritten@redhat.com>
24 files changed:
Makefile
ipsilon/admin/common.py
ipsilon/admin/loginstack.py
ipsilon/info/infoldap.py
ipsilon/info/infosssd.py
ipsilon/login/authfas.py
ipsilon/login/authform.py
ipsilon/login/authgssapi.py
ipsilon/login/authldap.py
ipsilon/login/authpam.py
ipsilon/login/authtest.py
ipsilon/login/common.py
ipsilon/providers/openid/auth.py
ipsilon/providers/saml2/admin.py
ipsilon/providers/saml2/auth.py
ipsilon/providers/saml2/provider.py
ipsilon/tools/files.py
ipsilon/util/config.py
ipsilon/util/data.py
ipsilon/util/endpoint.py
ipsilon/util/errors.py
ipsilon/util/page.py
ipsilon/util/user.py
tests/helpers/http.py