Fix OpenID AX extension bug

This makes sure that _display returns a dict, and that
the result from _resp can still be passed to addExtension

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Reviewed-by: Rob Crittenden <rcritten@redhat.com>

diff --git a/ipsilon/providers/openid/extensions/ax.py b/ipsilon/providers/openid/extensions/ax.py
index 10c3bb7..bf63d25 100644 (file)
--- a/ipsilon/providers/openid/extensions/ax.py
+++ b/ipsilon/providers/openid/extensions/ax.py
@@ -35,7 +35,7 @@ class OpenidExtension(OpenidExtensionBase):
     def _resp(self, request, userdata):
         req = ax.FetchRequest.fromOpenIDRequest(request)
         if req is None:
-            return {}
+            return None
         resp = ax.FetchResponse(req)
         for name in req.requested_attributes:
             try:
@@ -50,6 +50,8 @@ class OpenidExtension(OpenidExtensionBase):
 
     def _display(self, request, userdata):
         resp = self._resp(request, userdata)
+        if resp is None:
+            return {}
         data = dict()
         for name, value in resp.data.items():
             key = name