Fix some pylint warnings in logout test about shadowing variables.
authorRob Crittenden <rcritten@redhat.com>
Mon, 16 Mar 2015 20:39:02 +0000 (16:39 -0400)
committerRob Crittenden <rcritten@redhat.com>
Mon, 16 Mar 2015 20:54:15 +0000 (16:54 -0400)
Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Reviewed-by: Nathan Kinder <nkinder@redhat.com>
tests/testlogout.py

index b8e2712..b192739 100755 (executable)
@@ -103,7 +103,7 @@ Alias /open ${HTTPDIR}/open
         f.write(logged_out)
 
 
-def ensure_logout(sess, idpname, url):
+def ensure_logout(session, idp_name, spurl):
     """
     Fetch the secure page without following redirects. If we get
     a 303 then we should be redirected to the IDP for authentication
@@ -112,8 +112,9 @@ def ensure_logout(sess, idpname, url):
     Returns nothing or raises exception on error
     """
     try:
-        page = sess.fetch_page(idpname, url, follow_redirect=False)
-        if page.result.status_code != 303:
+        logout_page = session.fetch_page(idp_name, spurl,
+                                         follow_redirect=False)
+        if logout_page.result.status_code != 303:
             raise ValueError('Still logged into url')
     except ValueError:
         raise