Print exceptions when saving data fails in admin UI

There were places where a broad exception was caught when saving
administrative changes but the actual exception wasn't logged. The
user was presented only with a 'Failed to save data!' message.

https://fedorahosted.org/ipsilon/ticket/39

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Reviewed-by: Simo Sorce <simo@redhat.com>

diff --git a/ipsilon/admin/common.py b/ipsilon/admin/common.py
index b371fe9..fe92793 100644 (file)
--- a/ipsilon/admin/common.py
+++ b/ipsilon/admin/common.py
@@ -262,7 +262,8 @@ class AdminPluginConfig(AdminPage):
                 self._po.save_plugin_config(new_db_values)
                 message = "New configuration saved."
                 message_type = ADMIN_STATUS_OK
                 self._po.save_plugin_config(new_db_values)
                 message = "New configuration saved."
                 message_type = ADMIN_STATUS_OK

-            except Exception:  # pylint: disable=broad-except
+            except Exception as e:  # pylint: disable=broad-except
+                self.error('Failed to save data: %s' % e)

                 message = "Failed to save data!"
                 message_type = ADMIN_STATUS_ERROR
 
                 message = "Failed to save data!"
                 message_type = ADMIN_STATUS_ERROR
 


@@ -334,7 +335,8 @@ class AdminPluginsOrder(AdminPage):
                     message = str(e)
                     message_type = ADMIN_STATUS_ERROR
 
                     message = str(e)
                     message_type = ADMIN_STATUS_ERROR
 

-                except Exception, e:  # pylint: disable=broad-except
+                except Exception as e:  # pylint: disable=broad-except
+                    self.error('Failed to save data: %s' % e)

                     message = "Failed to save data!"
                     message_type = ADMIN_STATUS_ERROR
 
                     message = "Failed to save data!"
                     message_type = ADMIN_STATUS_ERROR
 

diff --git a/ipsilon/providers/saml2/admin.py b/ipsilon/providers/saml2/admin.py
index 2503be1..d5a5bdf 100644 (file)
--- a/ipsilon/providers/saml2/admin.py
+++ b/ipsilon/providers/saml2/admin.py
@@ -255,7 +255,8 @@ class SPAdminPage(AdminPage):
                     self.parent.rename_sp(rename[0], rename[1])
                 message = "Properties successfully changed"
                 message_type = ADMIN_STATUS_OK
                     self.parent.rename_sp(rename[0], rename[1])
                 message = "Properties successfully changed"
                 message_type = ADMIN_STATUS_OK

-            except Exception:  # pylint: disable=broad-except
+            except Exception, e:  # pylint: disable=broad-except
+                self.error('Failed to save data: %s' % e)

                 message = "Failed to save data!"
                 message_type = ADMIN_STATUS_ERROR
 
                 message = "Failed to save data!"
                 message_type = ADMIN_STATUS_ERROR