From: Simo Sorce <simo@redhat.com>
Date: Fri, 29 Aug 2014 22:04:49 +0000 (-0400)
Subject: Remove service name from the form plugin
X-Git-Tag: v0.3.0~96
X-Git-Url: http://git.cascardo.info/?p=cascardo%2Fipsilon.git;a=commitdiff_plain;h=7483cfa79415a18f73c29cb7a19e3f91e7945334

Remove service name from the form plugin

When using the external apache modules for form based authentication,
the pam service name is set in the apache config files and cannot be
dynamically changed, do not offr it as a configuration option.

Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Patrick Uiterwijk <puiterwijk@redhat.com>
---

diff --git a/ipsilon/login/authform.py b/ipsilon/login/authform.py
index 85b31bd..4c812db 100755
--- a/ipsilon/login/authform.py
+++ b/ipsilon/login/authform.py
@@ -50,15 +50,11 @@ class LoginManager(LoginManagerBase):
         self.name = 'form'
         self.path = 'form'
         self.page = None
+        self.service_name = 'form'
         self.description = """
 Form based login Manager. Relies on mod_intercept_form_submit plugin for
  actual authentication. """
         self._options = {
-            'service name': [
-                """ The name of the PAM service used to authenticate. """,
-                'string',
-                'remote'
-            ],
             'help text': [
                 """ The text shown to guide the user at login time. """,
                 'string',
@@ -76,10 +72,6 @@ Form based login Manager. Relies on mod_intercept_form_submit plugin for
             ],
         }
 
-    @property
-    def service_name(self):
-        return self.get_config_value('service name')
-
     @property
     def help_text(self):
         return self.get_config_value('help text')