From: Rob Crittenden <rcritten@redhat.com>
Date: Fri, 8 May 2015 13:46:24 +0000 (-0400)
Subject: Remove extraneous logging arg in authform login plugin
X-Git-Tag: v1.0.0~20
X-Git-Url: http://git.cascardo.info/?p=cascardo%2Fipsilon.git;a=commitdiff_plain;h=7a2a221318198717f9526ea521dc65cdf73b587d

Remove extraneous logging arg in authform login plugin

If you didn't provide credentials at all at the form by
pressing ENTER then a 500 error would be thrown rather
than an authentication error.

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Reviewed-by: Patrick Uiterwijk <puiterwijk@redhat.com>
---

diff --git a/ipsilon/login/authform.py b/ipsilon/login/authform.py
index 0e20a60..55dc6b3 100644
--- a/ipsilon/login/authform.py
+++ b/ipsilon/login/authform.py
@@ -23,7 +23,6 @@ from ipsilon.util import config as pconfig
 from string import Template
 import cherrypy
 import subprocess
-import logging
 
 
 class Form(LoginFormBase):
@@ -39,7 +38,7 @@ class Form(LoginFormBase):
                 error = cherrypy.request.headers['EXTERNAL_AUTH_ERROR']
             except KeyError:
                 error = "Unknown error using external authentication"
-                cherrypy.log.error("Error: %s" % error, logging.ERROR)
+                cherrypy.log.error("Error: %s" % error)
             return self.lm.auth_failed(self.trans)