From ba45934659346510966ca6c58a01dbba3eca7d2f Mon Sep 17 00:00:00 2001 From: Patrick Uiterwijk Date: Mon, 27 Apr 2015 22:22:05 +0200 Subject: [PATCH] Fix OpenID AX extension bug This makes sure that _display returns a dict, and that the result from _resp can still be passed to addExtension Signed-off-by: Patrick Uiterwijk Reviewed-by: Rob Crittenden --- ipsilon/providers/openid/extensions/ax.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ipsilon/providers/openid/extensions/ax.py b/ipsilon/providers/openid/extensions/ax.py index 10c3bb7..bf63d25 100644 --- a/ipsilon/providers/openid/extensions/ax.py +++ b/ipsilon/providers/openid/extensions/ax.py @@ -35,7 +35,7 @@ class OpenidExtension(OpenidExtensionBase): def _resp(self, request, userdata): req = ax.FetchRequest.fromOpenIDRequest(request) if req is None: - return {} + return None resp = ax.FetchResponse(req) for name in req.requested_attributes: try: @@ -50,6 +50,8 @@ class OpenidExtension(OpenidExtensionBase): def _display(self, request, userdata): resp = self._resp(request, userdata) + if resp is None: + return {} data = dict() for name, value in resp.data.items(): key = name -- 2.20.1