From bae1c5592da11f1fb2b9930730cf6acae942f3dc Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Mon, 16 Mar 2015 16:39:02 -0400 Subject: [PATCH 1/1] Fix some pylint warnings in logout test about shadowing variables. Signed-off-by: Rob Crittenden Reviewed-by: Nathan Kinder --- tests/testlogout.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/testlogout.py b/tests/testlogout.py index b8e2712..b192739 100755 --- a/tests/testlogout.py +++ b/tests/testlogout.py @@ -103,7 +103,7 @@ Alias /open ${HTTPDIR}/open f.write(logged_out) -def ensure_logout(sess, idpname, url): +def ensure_logout(session, idp_name, spurl): """ Fetch the secure page without following redirects. If we get a 303 then we should be redirected to the IDP for authentication @@ -112,8 +112,9 @@ def ensure_logout(sess, idpname, url): Returns nothing or raises exception on error """ try: - page = sess.fetch_page(idpname, url, follow_redirect=False) - if page.result.status_code != 303: + logout_page = session.fetch_page(idp_name, spurl, + follow_redirect=False) + if logout_page.result.status_code != 303: raise ValueError('Still logged into url') except ValueError: raise -- 2.20.1