drm/gem: Warn on illegal use of the dumb buffer interface v2
[cascardo/linux.git] / drivers / gpu / drm / i915 / i915_drv.c
index 808f659..c743908 100644 (file)
@@ -551,8 +551,8 @@ static void intel_suspend_encoders(struct drm_i915_private *dev_priv)
 }
 
 static int intel_suspend_complete(struct drm_i915_private *dev_priv);
-static int intel_resume_prepare(struct drm_i915_private *dev_priv,
-                               bool rpm_resume);
+static int vlv_resume_prepare(struct drm_i915_private *dev_priv,
+                             bool rpm_resume);
 
 static int i915_drm_suspend(struct drm_device *dev)
 {
@@ -649,7 +649,7 @@ static int i915_drm_suspend_late(struct drm_device *drm_dev)
        return 0;
 }
 
-int i915_suspend(struct drm_device *dev, pm_message_t state)
+int i915_suspend_legacy(struct drm_device *dev, pm_message_t state)
 {
        int error;
 
@@ -744,7 +744,7 @@ static int i915_drm_resume(struct drm_device *dev)
 static int i915_drm_resume_early(struct drm_device *dev)
 {
        struct drm_i915_private *dev_priv = dev->dev_private;
-       int ret;
+       int ret = 0;
 
        /*
         * We have a resume ordering issue with the snd-hda driver also
@@ -760,18 +760,23 @@ static int i915_drm_resume_early(struct drm_device *dev)
 
        pci_set_master(dev->pdev);
 
-       ret = intel_resume_prepare(dev_priv, false);
+       if (IS_VALLEYVIEW(dev_priv))
+               ret = vlv_resume_prepare(dev_priv, false);
        if (ret)
                DRM_ERROR("Resume prepare failed: %d,Continuing resume\n", ret);
 
        intel_uncore_early_sanitize(dev, true);
+
+       if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
+               hsw_disable_pc8(dev_priv);
+
        intel_uncore_sanitize(dev);
        intel_power_domains_init_hw(dev_priv);
 
        return ret;
 }
 
-static int i915_resume_legacy(struct drm_device *dev)
+int i915_resume_legacy(struct drm_device *dev)
 {
        int ret;
 
@@ -785,11 +790,6 @@ static int i915_resume_legacy(struct drm_device *dev)
        return i915_drm_resume(dev);
 }
 
-int i915_resume(struct drm_device *dev)
-{
-       return i915_resume_legacy(dev);
-}
-
 /**
  * i915_reset - reset chip after a hang
  * @dev: drm device to reset
@@ -991,25 +991,6 @@ static int hsw_suspend_complete(struct drm_i915_private *dev_priv)
        return 0;
 }
 
-static int snb_resume_prepare(struct drm_i915_private *dev_priv,
-                               bool rpm_resume)
-{
-       struct drm_device *dev = dev_priv->dev;
-
-       if (rpm_resume)
-               intel_init_pch_refclk(dev);
-
-       return 0;
-}
-
-static int hsw_resume_prepare(struct drm_i915_private *dev_priv,
-                               bool rpm_resume)
-{
-       hsw_disable_pc8(dev_priv);
-
-       return 0;
-}
-
 /*
  * Save all Gunit registers that may be lost after a D3 and a subsequent
  * S0i[R123] transition. The list of registers needing a save/restore is
@@ -1414,13 +1395,9 @@ static int intel_runtime_suspend(struct device *device)
        i915_gem_release_all_mmaps(dev_priv);
        mutex_unlock(&dev->struct_mutex);
 
-       /*
-        * rps.work can't be rearmed here, since we get here only after making
-        * sure the GPU is idle and the RPS freq is set to the minimum. See
-        * intel_mark_idle().
-        */
-       cancel_work_sync(&dev_priv->rps.work);
+       flush_delayed_work(&dev_priv->rps.delayed_resume_work);
        intel_runtime_pm_disable_interrupts(dev_priv);
+       intel_suspend_gt_powersave(dev);
 
        ret = intel_suspend_complete(dev_priv);
        if (ret) {
@@ -1467,7 +1444,7 @@ static int intel_runtime_resume(struct device *device)
        struct pci_dev *pdev = to_pci_dev(device);
        struct drm_device *dev = pci_get_drvdata(pdev);
        struct drm_i915_private *dev_priv = dev->dev_private;
-       int ret;
+       int ret = 0;
 
        if (WARN_ON_ONCE(!HAS_RUNTIME_PM(dev)))
                return -ENODEV;
@@ -1477,7 +1454,13 @@ static int intel_runtime_resume(struct device *device)
        intel_opregion_notify_adapter(dev, PCI_D0);
        dev_priv->pm.suspended = false;
 
-       ret = intel_resume_prepare(dev_priv, true);
+       if (IS_GEN6(dev_priv))
+               intel_init_pch_refclk(dev);
+       else if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
+               hsw_disable_pc8(dev_priv);
+       else if (IS_VALLEYVIEW(dev_priv))
+               ret = vlv_resume_prepare(dev_priv, true);
+
        /*
         * No point of rolling back things in case of an error, as the best
         * we can do is to hope that things will still work (and disable RPM).
@@ -1486,7 +1469,7 @@ static int intel_runtime_resume(struct device *device)
        gen6_update_ring_freq(dev);
 
        intel_runtime_pm_enable_interrupts(dev_priv);
-       intel_reset_gt_powersave(dev);
+       intel_enable_gt_powersave(dev);
 
        if (ret)
                DRM_ERROR("Runtime resume failed, disabling it (%d)\n", ret);
@@ -1515,34 +1498,31 @@ static int intel_suspend_complete(struct drm_i915_private *dev_priv)
        return ret;
 }
 
-/*
- * This function implements common functionality of runtime and system
- * resume sequence. Variable rpm_resume used for implementing different
- * code paths.
- */
-static int intel_resume_prepare(struct drm_i915_private *dev_priv,
-                               bool rpm_resume)
-{
-       struct drm_device *dev = dev_priv->dev;
-       int ret;
-
-       if (IS_GEN6(dev))
-               ret = snb_resume_prepare(dev_priv, rpm_resume);
-       else if (IS_HASWELL(dev) || IS_BROADWELL(dev))
-               ret = hsw_resume_prepare(dev_priv, rpm_resume);
-       else if (IS_VALLEYVIEW(dev))
-               ret = vlv_resume_prepare(dev_priv, rpm_resume);
-       else
-               ret = 0;
-
-       return ret;
-}
-
 static const struct dev_pm_ops i915_pm_ops = {
+       /*
+        * S0ix (via system suspend) and S3 event handlers [PMSG_SUSPEND,
+        * PMSG_RESUME]
+        */
        .suspend = i915_pm_suspend,
        .suspend_late = i915_pm_suspend_late,
        .resume_early = i915_pm_resume_early,
        .resume = i915_pm_resume,
+
+       /*
+        * S4 event handlers
+        * @freeze, @freeze_late    : called (1) before creating the
+        *                            hibernation image [PMSG_FREEZE] and
+        *                            (2) after rebooting, before restoring
+        *                            the image [PMSG_QUIESCE]
+        * @thaw, @thaw_early       : called (1) after creating the hibernation
+        *                            image, before writing it [PMSG_THAW]
+        *                            and (2) after failing to create or
+        *                            restore the image [PMSG_RECOVER]
+        * @poweroff, @poweroff_late: called after writing the hibernation
+        *                            image, before rebooting [PMSG_HIBERNATE]
+        * @restore, @restore_early : called after rebooting and restoring the
+        *                            hibernation image [PMSG_RESTORE]
+        */
        .freeze = i915_pm_suspend,
        .freeze_late = i915_pm_suspend_late,
        .thaw_early = i915_pm_resume_early,
@@ -1551,6 +1531,8 @@ static const struct dev_pm_ops i915_pm_ops = {
        .poweroff_late = i915_pm_suspend_late,
        .restore_early = i915_pm_resume_early,
        .restore = i915_pm_resume,
+
+       /* S0ix (via runtime suspend) event handlers */
        .runtime_suspend = intel_runtime_suspend,
        .runtime_resume = intel_runtime_resume,
 };
@@ -1592,7 +1574,7 @@ static struct drm_driver driver = {
        .set_busid = drm_pci_set_busid,
 
        /* Used in place of i915_pm_ops for non-DRIVER_MODESET */
-       .suspend = i915_suspend,
+       .suspend = i915_suspend_legacy,
        .resume = i915_resume_legacy,
 
        .device_is_agp = i915_driver_device_is_agp,
@@ -1611,7 +1593,7 @@ static struct drm_driver driver = {
        .gem_prime_import = i915_gem_prime_import,
 
        .dumb_create = i915_gem_dumb_create,
-       .dumb_map_offset = i915_gem_mmap_gtt,
+       .dumb_map_offset = i915_gem_dumb_map_offset,
        .dumb_destroy = drm_gem_dumb_destroy,
        .ioctls = i915_ioctls,
        .fops = &i915_driver_fops,