net/mlx5e: Split the main flow steering table
[cascardo/linux.git] / drivers / net / ethernet / mellanox / mlx5 / core / en_fs.c
index 3ee35b0..6e353b3 100644 (file)
 #include <linux/mlx5/fs.h>
 #include "en.h"
 
+static int mlx5e_add_l2_flow_rule(struct mlx5e_priv *priv,
+                                 struct mlx5e_l2_rule *ai, int type);
+static void mlx5e_del_l2_flow_rule(struct mlx5e_priv *priv,
+                                  struct mlx5e_l2_rule *ai);
+
+/* NIC prio FTS */
 enum {
        MLX5E_VLAN_FT_LEVEL = 0,
-       MLX5E_MAIN_FT_LEVEL
+       MLX5E_L2_FT_LEVEL,
+       MLX5E_TTC_FT_LEVEL
 };
 
 #define MLX5_SET_CFG(p, f, v) MLX5_SET(create_flow_group_in, p, f, v)
@@ -63,21 +70,21 @@ enum {
        MLX5E_ACTION_DEL  = 2,
 };
 
-struct mlx5e_eth_addr_hash_node {
+struct mlx5e_l2_hash_node {
        struct hlist_node          hlist;
        u8                         action;
-       struct mlx5e_eth_addr_info ai;
+       struct mlx5e_l2_rule ai;
 };
 
-static inline int mlx5e_hash_eth_addr(u8 *addr)
+static inline int mlx5e_hash_l2(u8 *addr)
 {
        return addr[5];
 }
 
-static void mlx5e_add_eth_addr_to_hash(struct hlist_head *hash, u8 *addr)
+static void mlx5e_add_l2_to_hash(struct hlist_head *hash, u8 *addr)
 {
-       struct mlx5e_eth_addr_hash_node *hn;
-       int ix = mlx5e_hash_eth_addr(addr);
+       struct mlx5e_l2_hash_node *hn;
+       int ix = mlx5e_hash_l2(addr);
        int found = 0;
 
        hlist_for_each_entry(hn, &hash[ix], hlist)
@@ -101,371 +108,12 @@ static void mlx5e_add_eth_addr_to_hash(struct hlist_head *hash, u8 *addr)
        hlist_add_head(&hn->hlist, &hash[ix]);
 }
 
-static void mlx5e_del_eth_addr_from_hash(struct mlx5e_eth_addr_hash_node *hn)
+static void mlx5e_del_l2_from_hash(struct mlx5e_l2_hash_node *hn)
 {
        hlist_del(&hn->hlist);
        kfree(hn);
 }
 
-static void mlx5e_del_eth_addr_from_flow_table(struct mlx5e_priv *priv,
-                                              struct mlx5e_eth_addr_info *ai)
-{
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV6_IPSEC_ESP))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV6_IPSEC_ESP]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV4_IPSEC_ESP))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV4_IPSEC_ESP]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV6_IPSEC_AH))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV6_IPSEC_AH]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV4_IPSEC_AH))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV4_IPSEC_AH]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV6_TCP))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV6_TCP]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV4_TCP))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV4_TCP]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV6_UDP))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV6_UDP]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV4_UDP))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV4_UDP]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV6))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV6]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_IPV4))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_IPV4]);
-
-       if (ai->tt_vec & BIT(MLX5E_TT_ANY))
-               mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_ANY]);
-}
-
-static int mlx5e_get_eth_addr_type(u8 *addr)
-{
-       if (is_unicast_ether_addr(addr))
-               return MLX5E_UC;
-
-       if ((addr[0] == 0x01) &&
-           (addr[1] == 0x00) &&
-           (addr[2] == 0x5e) &&
-          !(addr[3] &  0x80))
-               return MLX5E_MC_IPV4;
-
-       if ((addr[0] == 0x33) &&
-           (addr[1] == 0x33))
-               return MLX5E_MC_IPV6;
-
-       return MLX5E_MC_OTHER;
-}
-
-static u32 mlx5e_get_tt_vec(struct mlx5e_eth_addr_info *ai, int type)
-{
-       int eth_addr_type;
-       u32 ret;
-
-       switch (type) {
-       case MLX5E_FULLMATCH:
-               eth_addr_type = mlx5e_get_eth_addr_type(ai->addr);
-               switch (eth_addr_type) {
-               case MLX5E_UC:
-                       ret =
-                               BIT(MLX5E_TT_IPV4_TCP)       |
-                               BIT(MLX5E_TT_IPV6_TCP)       |
-                               BIT(MLX5E_TT_IPV4_UDP)       |
-                               BIT(MLX5E_TT_IPV6_UDP)       |
-                               BIT(MLX5E_TT_IPV4_IPSEC_AH)  |
-                               BIT(MLX5E_TT_IPV6_IPSEC_AH)  |
-                               BIT(MLX5E_TT_IPV4_IPSEC_ESP) |
-                               BIT(MLX5E_TT_IPV6_IPSEC_ESP) |
-                               BIT(MLX5E_TT_IPV4)           |
-                               BIT(MLX5E_TT_IPV6)           |
-                               BIT(MLX5E_TT_ANY)            |
-                               0;
-                       break;
-
-               case MLX5E_MC_IPV4:
-                       ret =
-                               BIT(MLX5E_TT_IPV4_UDP)       |
-                               BIT(MLX5E_TT_IPV4)           |
-                               0;
-                       break;
-
-               case MLX5E_MC_IPV6:
-                       ret =
-                               BIT(MLX5E_TT_IPV6_UDP)       |
-                               BIT(MLX5E_TT_IPV6)           |
-                               0;
-                       break;
-
-               case MLX5E_MC_OTHER:
-                       ret =
-                               BIT(MLX5E_TT_ANY)            |
-                               0;
-                       break;
-               }
-
-               break;
-
-       case MLX5E_ALLMULTI:
-               ret =
-                       BIT(MLX5E_TT_IPV4_UDP) |
-                       BIT(MLX5E_TT_IPV6_UDP) |
-                       BIT(MLX5E_TT_IPV4)     |
-                       BIT(MLX5E_TT_IPV6)     |
-                       BIT(MLX5E_TT_ANY)      |
-                       0;
-               break;
-
-       default: /* MLX5E_PROMISC */
-               ret =
-                       BIT(MLX5E_TT_IPV4_TCP)       |
-                       BIT(MLX5E_TT_IPV6_TCP)       |
-                       BIT(MLX5E_TT_IPV4_UDP)       |
-                       BIT(MLX5E_TT_IPV6_UDP)       |
-                       BIT(MLX5E_TT_IPV4_IPSEC_AH)  |
-                       BIT(MLX5E_TT_IPV6_IPSEC_AH)  |
-                       BIT(MLX5E_TT_IPV4_IPSEC_ESP) |
-                       BIT(MLX5E_TT_IPV6_IPSEC_ESP) |
-                       BIT(MLX5E_TT_IPV4)           |
-                       BIT(MLX5E_TT_IPV6)           |
-                       BIT(MLX5E_TT_ANY)            |
-                       0;
-               break;
-       }
-
-       return ret;
-}
-
-static int __mlx5e_add_eth_addr_rule(struct mlx5e_priv *priv,
-                                    struct mlx5e_eth_addr_info *ai,
-                                    int type, u32 *mc, u32 *mv)
-{
-       struct mlx5_flow_destination dest;
-       u8 match_criteria_enable = 0;
-       struct mlx5_flow_rule **rule_p;
-       struct mlx5_flow_table *ft = priv->fs.main.ft.t;
-       u8 *mc_dmac = MLX5_ADDR_OF(fte_match_param, mc,
-                                  outer_headers.dmac_47_16);
-       u8 *mv_dmac = MLX5_ADDR_OF(fte_match_param, mv,
-                                  outer_headers.dmac_47_16);
-       u32 *tirn = priv->indir_tirn;
-       u32 tt_vec;
-       int err = 0;
-
-       dest.type = MLX5_FLOW_DESTINATION_TYPE_TIR;
-
-       switch (type) {
-       case MLX5E_FULLMATCH:
-               match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;
-               eth_broadcast_addr(mc_dmac);
-               ether_addr_copy(mv_dmac, ai->addr);
-               break;
-
-       case MLX5E_ALLMULTI:
-               match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;
-               mc_dmac[0] = 0x01;
-               mv_dmac[0] = 0x01;
-               break;
-
-       case MLX5E_PROMISC:
-               break;
-       }
-
-       tt_vec = mlx5e_get_tt_vec(ai, type);
-
-       if (tt_vec & BIT(MLX5E_TT_ANY)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_ANY];
-               dest.tir_num = priv->direct_tir[0].tirn;
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_ANY);
-       }
-
-       match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ethertype);
-
-       if (tt_vec & BIT(MLX5E_TT_IPV4)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV4];
-               dest.tir_num = tirn[MLX5E_TT_IPV4];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IP);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV4);
-       }
-
-       if (tt_vec & BIT(MLX5E_TT_IPV6)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV6];
-               dest.tir_num = tirn[MLX5E_TT_IPV6];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IPV6);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV6);
-       }
-
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ip_protocol);
-       MLX5_SET(fte_match_param, mv, outer_headers.ip_protocol, IPPROTO_UDP);
-
-       if (tt_vec & BIT(MLX5E_TT_IPV4_UDP)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV4_UDP];
-               dest.tir_num = tirn[MLX5E_TT_IPV4_UDP];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IP);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV4_UDP);
-       }
-
-       if (tt_vec & BIT(MLX5E_TT_IPV6_UDP)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV6_UDP];
-               dest.tir_num = tirn[MLX5E_TT_IPV6_UDP];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IPV6);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV6_UDP);
-       }
-
-       MLX5_SET(fte_match_param, mv, outer_headers.ip_protocol, IPPROTO_TCP);
-
-       if (tt_vec & BIT(MLX5E_TT_IPV4_TCP)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV4_TCP];
-               dest.tir_num = tirn[MLX5E_TT_IPV4_TCP];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IP);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV4_TCP);
-       }
-
-       if (tt_vec & BIT(MLX5E_TT_IPV6_TCP)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV6_TCP];
-               dest.tir_num = tirn[MLX5E_TT_IPV6_TCP];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IPV6);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-
-               ai->tt_vec |= BIT(MLX5E_TT_IPV6_TCP);
-       }
-
-       MLX5_SET(fte_match_param, mv, outer_headers.ip_protocol, IPPROTO_AH);
-
-       if (tt_vec & BIT(MLX5E_TT_IPV4_IPSEC_AH)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV4_IPSEC_AH];
-               dest.tir_num = tirn[MLX5E_TT_IPV4_IPSEC_AH];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IP);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV4_IPSEC_AH);
-       }
-
-       if (tt_vec & BIT(MLX5E_TT_IPV6_IPSEC_AH)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV6_IPSEC_AH];
-               dest.tir_num = tirn[MLX5E_TT_IPV6_IPSEC_AH];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IPV6);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV6_IPSEC_AH);
-       }
-
-       MLX5_SET(fte_match_param, mv, outer_headers.ip_protocol, IPPROTO_ESP);
-
-       if (tt_vec & BIT(MLX5E_TT_IPV4_IPSEC_ESP)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV4_IPSEC_ESP];
-               dest.tir_num = tirn[MLX5E_TT_IPV4_IPSEC_ESP];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IP);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV4_IPSEC_ESP);
-       }
-
-       if (tt_vec & BIT(MLX5E_TT_IPV6_IPSEC_ESP)) {
-               rule_p = &ai->ft_rule[MLX5E_TT_IPV6_IPSEC_ESP];
-               dest.tir_num = tirn[MLX5E_TT_IPV6_IPSEC_ESP];
-               MLX5_SET(fte_match_param, mv, outer_headers.ethertype,
-                        ETH_P_IPV6);
-               *rule_p = mlx5_add_flow_rule(ft, match_criteria_enable, mc, mv,
-                                            MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
-                                            MLX5_FS_DEFAULT_FLOW_TAG, &dest);
-               if (IS_ERR_OR_NULL(*rule_p))
-                       goto err_del_ai;
-               ai->tt_vec |= BIT(MLX5E_TT_IPV6_IPSEC_ESP);
-       }
-
-       return 0;
-
-err_del_ai:
-       err = PTR_ERR(*rule_p);
-       *rule_p = NULL;
-       mlx5e_del_eth_addr_from_flow_table(priv, ai);
-
-       return err;
-}
-
-static int mlx5e_add_eth_addr_rule(struct mlx5e_priv *priv,
-                                  struct mlx5e_eth_addr_info *ai, int type)
-{
-       u32 *match_criteria;
-       u32 *match_value;
-       int err = 0;
-
-       match_value     = mlx5_vzalloc(MLX5_ST_SZ_BYTES(fte_match_param));
-       match_criteria  = mlx5_vzalloc(MLX5_ST_SZ_BYTES(fte_match_param));
-       if (!match_value || !match_criteria) {
-               netdev_err(priv->netdev, "%s: alloc failed\n", __func__);
-               err = -ENOMEM;
-               goto add_eth_addr_rule_out;
-       }
-
-       err = __mlx5e_add_eth_addr_rule(priv, ai, type, match_criteria,
-                                       match_value);
-
-add_eth_addr_rule_out:
-       kvfree(match_criteria);
-       kvfree(match_value);
-
-       return err;
-}
-
 static int mlx5e_vport_context_update_vlans(struct mlx5e_priv *priv)
 {
        struct net_device *ndev = priv->netdev;
@@ -526,7 +174,7 @@ static int __mlx5e_add_vlan_rule(struct mlx5e_priv *priv,
        int err = 0;
 
        dest.type = MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;
-       dest.ft = priv->fs.main.ft.t;
+       dest.ft = priv->fs.l2.ft.t;
 
        match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;
        MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.vlan_tag);
@@ -661,21 +309,21 @@ int mlx5e_vlan_rx_kill_vid(struct net_device *dev, __always_unused __be16 proto,
 }
 
 #define mlx5e_for_each_hash_node(hn, tmp, hash, i) \
-       for (i = 0; i < MLX5E_ETH_ADDR_HASH_SIZE; i++) \
+       for (i = 0; i < MLX5E_L2_ADDR_HASH_SIZE; i++) \
                hlist_for_each_entry_safe(hn, tmp, &hash[i], hlist)
 
-static void mlx5e_execute_action(struct mlx5e_priv *priv,
-                                struct mlx5e_eth_addr_hash_node *hn)
+static void mlx5e_execute_l2_action(struct mlx5e_priv *priv,
+                                   struct mlx5e_l2_hash_node *hn)
 {
        switch (hn->action) {
        case MLX5E_ACTION_ADD:
-               mlx5e_add_eth_addr_rule(priv, &hn->ai, MLX5E_FULLMATCH);
+               mlx5e_add_l2_flow_rule(priv, &hn->ai, MLX5E_FULLMATCH);
                hn->action = MLX5E_ACTION_NONE;
                break;
 
        case MLX5E_ACTION_DEL:
-               mlx5e_del_eth_addr_from_flow_table(priv, &hn->ai);
-               mlx5e_del_eth_addr_from_hash(hn);
+               mlx5e_del_l2_flow_rule(priv, &hn->ai);
+               mlx5e_del_l2_from_hash(hn);
                break;
        }
 }
@@ -687,14 +335,14 @@ static void mlx5e_sync_netdev_addr(struct mlx5e_priv *priv)
 
        netif_addr_lock_bh(netdev);
 
-       mlx5e_add_eth_addr_to_hash(priv->fs.main.netdev_uc,
-                                  priv->netdev->dev_addr);
+       mlx5e_add_l2_to_hash(priv->fs.l2.netdev_uc,
+                            priv->netdev->dev_addr);
 
        netdev_for_each_uc_addr(ha, netdev)
-               mlx5e_add_eth_addr_to_hash(priv->fs.main.netdev_uc, ha->addr);
+               mlx5e_add_l2_to_hash(priv->fs.l2.netdev_uc, ha->addr);
 
        netdev_for_each_mc_addr(ha, netdev)
-               mlx5e_add_eth_addr_to_hash(priv->fs.main.netdev_mc, ha->addr);
+               mlx5e_add_l2_to_hash(priv->fs.l2.netdev_mc, ha->addr);
 
        netif_addr_unlock_bh(netdev);
 }
@@ -704,17 +352,17 @@ static void mlx5e_fill_addr_array(struct mlx5e_priv *priv, int list_type,
 {
        bool is_uc = (list_type == MLX5_NVPRT_LIST_TYPE_UC);
        struct net_device *ndev = priv->netdev;
-       struct mlx5e_eth_addr_hash_node *hn;
+       struct mlx5e_l2_hash_node *hn;
        struct hlist_head *addr_list;
        struct hlist_node *tmp;
        int i = 0;
        int hi;
 
-       addr_list = is_uc ? priv->fs.main.netdev_uc : priv->fs.main.netdev_mc;
+       addr_list = is_uc ? priv->fs.l2.netdev_uc : priv->fs.l2.netdev_mc;
 
        if (is_uc) /* Make sure our own address is pushed first */
                ether_addr_copy(addr_array[i++], ndev->dev_addr);
-       else if (priv->fs.main.broadcast_enabled)
+       else if (priv->fs.l2.broadcast_enabled)
                ether_addr_copy(addr_array[i++], ndev->broadcast);
 
        mlx5e_for_each_hash_node(hn, tmp, addr_list, hi) {
@@ -730,7 +378,7 @@ static void mlx5e_vport_context_update_addr_list(struct mlx5e_priv *priv,
                                                 int list_type)
 {
        bool is_uc = (list_type == MLX5_NVPRT_LIST_TYPE_UC);
-       struct mlx5e_eth_addr_hash_node *hn;
+       struct mlx5e_l2_hash_node *hn;
        u8 (*addr_array)[ETH_ALEN] = NULL;
        struct hlist_head *addr_list;
        struct hlist_node *tmp;
@@ -739,12 +387,12 @@ static void mlx5e_vport_context_update_addr_list(struct mlx5e_priv *priv,
        int err;
        int hi;
 
-       size = is_uc ? 0 : (priv->fs.main.broadcast_enabled ? 1 : 0);
+       size = is_uc ? 0 : (priv->fs.l2.broadcast_enabled ? 1 : 0);
        max_size = is_uc ?
                1 << MLX5_CAP_GEN(priv->mdev, log_max_current_uc_list) :
                1 << MLX5_CAP_GEN(priv->mdev, log_max_current_mc_list);
 
-       addr_list = is_uc ? priv->fs.main.netdev_uc : priv->fs.main.netdev_mc;
+       addr_list = is_uc ? priv->fs.l2.netdev_uc : priv->fs.l2.netdev_mc;
        mlx5e_for_each_hash_node(hn, tmp, addr_list, hi)
                size++;
 
@@ -775,37 +423,37 @@ out:
 
 static void mlx5e_vport_context_update(struct mlx5e_priv *priv)
 {
-       struct mlx5e_main_table *main_table = &priv->fs.main;
+       struct mlx5e_l2_table *ea = &priv->fs.l2;
 
        mlx5e_vport_context_update_addr_list(priv, MLX5_NVPRT_LIST_TYPE_UC);
        mlx5e_vport_context_update_addr_list(priv, MLX5_NVPRT_LIST_TYPE_MC);
        mlx5_modify_nic_vport_promisc(priv->mdev, 0,
-                                     main_table->allmulti_enabled,
-                                     main_table->promisc_enabled);
+                                     ea->allmulti_enabled,
+                                     ea->promisc_enabled);
 }
 
 static void mlx5e_apply_netdev_addr(struct mlx5e_priv *priv)
 {
-       struct mlx5e_eth_addr_hash_node *hn;
+       struct mlx5e_l2_hash_node *hn;
        struct hlist_node *tmp;
        int i;
 
-       mlx5e_for_each_hash_node(hn, tmp, priv->fs.main.netdev_uc, i)
-               mlx5e_execute_action(priv, hn);
+       mlx5e_for_each_hash_node(hn, tmp, priv->fs.l2.netdev_uc, i)
+               mlx5e_execute_l2_action(priv, hn);
 
-       mlx5e_for_each_hash_node(hn, tmp, priv->fs.main.netdev_mc, i)
-               mlx5e_execute_action(priv, hn);
+       mlx5e_for_each_hash_node(hn, tmp, priv->fs.l2.netdev_mc, i)
+               mlx5e_execute_l2_action(priv, hn);
 }
 
 static void mlx5e_handle_netdev_addr(struct mlx5e_priv *priv)
 {
-       struct mlx5e_eth_addr_hash_node *hn;
+       struct mlx5e_l2_hash_node *hn;
        struct hlist_node *tmp;
        int i;
 
-       mlx5e_for_each_hash_node(hn, tmp, priv->fs.main.netdev_uc, i)
+       mlx5e_for_each_hash_node(hn, tmp, priv->fs.l2.netdev_uc, i)
                hn->action = MLX5E_ACTION_DEL;
-       mlx5e_for_each_hash_node(hn, tmp, priv->fs.main.netdev_mc, i)
+       mlx5e_for_each_hash_node(hn, tmp, priv->fs.l2.netdev_mc, i)
                hn->action = MLX5E_ACTION_DEL;
 
        if (!test_bit(MLX5E_STATE_DESTROYING, &priv->state))
@@ -819,7 +467,7 @@ void mlx5e_set_rx_mode_work(struct work_struct *work)
        struct mlx5e_priv *priv = container_of(work, struct mlx5e_priv,
                                               set_rx_mode_work);
 
-       struct mlx5e_main_table *main_table = &priv->fs.main;
+       struct mlx5e_l2_table *ea = &priv->fs.l2;
        struct net_device *ndev = priv->netdev;
 
        bool rx_mode_enable   = !test_bit(MLX5E_STATE_DESTROYING, &priv->state);
@@ -827,40 +475,40 @@ void mlx5e_set_rx_mode_work(struct work_struct *work)
        bool allmulti_enabled  = rx_mode_enable && (ndev->flags & IFF_ALLMULTI);
        bool broadcast_enabled = rx_mode_enable;
 
-       bool enable_promisc    = !main_table->promisc_enabled   &&  promisc_enabled;
-       bool disable_promisc   =  main_table->promisc_enabled   && !promisc_enabled;
-       bool enable_allmulti   = !main_table->allmulti_enabled  &&  allmulti_enabled;
-       bool disable_allmulti  =  main_table->allmulti_enabled  && !allmulti_enabled;
-       bool enable_broadcast  = !main_table->broadcast_enabled &&  broadcast_enabled;
-       bool disable_broadcast =  main_table->broadcast_enabled && !broadcast_enabled;
+       bool enable_promisc    = !ea->promisc_enabled   &&  promisc_enabled;
+       bool disable_promisc   =  ea->promisc_enabled   && !promisc_enabled;
+       bool enable_allmulti   = !ea->allmulti_enabled  &&  allmulti_enabled;
+       bool disable_allmulti  =  ea->allmulti_enabled  && !allmulti_enabled;
+       bool enable_broadcast  = !ea->broadcast_enabled &&  broadcast_enabled;
+       bool disable_broadcast =  ea->broadcast_enabled && !broadcast_enabled;
 
        if (enable_promisc) {
-               mlx5e_add_eth_addr_rule(priv, &main_table->promisc, MLX5E_PROMISC);
+               mlx5e_add_l2_flow_rule(priv, &ea->promisc, MLX5E_PROMISC);
                if (!priv->fs.vlan.filter_disabled)
                        mlx5e_add_vlan_rule(priv, MLX5E_VLAN_RULE_TYPE_ANY_VID,
                                            0);
        }
        if (enable_allmulti)
-               mlx5e_add_eth_addr_rule(priv, &main_table->allmulti, MLX5E_ALLMULTI);
+               mlx5e_add_l2_flow_rule(priv, &ea->allmulti, MLX5E_ALLMULTI);
        if (enable_broadcast)
-               mlx5e_add_eth_addr_rule(priv, &main_table->broadcast, MLX5E_FULLMATCH);
+               mlx5e_add_l2_flow_rule(priv, &ea->broadcast, MLX5E_FULLMATCH);
 
        mlx5e_handle_netdev_addr(priv);
 
        if (disable_broadcast)
-               mlx5e_del_eth_addr_from_flow_table(priv, &main_table->broadcast);
+               mlx5e_del_l2_flow_rule(priv, &ea->broadcast);
        if (disable_allmulti)
-               mlx5e_del_eth_addr_from_flow_table(priv, &main_table->allmulti);
+               mlx5e_del_l2_flow_rule(priv, &ea->allmulti);
        if (disable_promisc) {
                if (!priv->fs.vlan.filter_disabled)
                        mlx5e_del_vlan_rule(priv, MLX5E_VLAN_RULE_TYPE_ANY_VID,
                                            0);
-               mlx5e_del_eth_addr_from_flow_table(priv, &main_table->promisc);
+               mlx5e_del_l2_flow_rule(priv, &ea->promisc);
        }
 
-       main_table->promisc_enabled   = promisc_enabled;
-       main_table->allmulti_enabled  = allmulti_enabled;
-       main_table->broadcast_enabled = broadcast_enabled;
+       ea->promisc_enabled   = promisc_enabled;
+       ea->allmulti_enabled  = allmulti_enabled;
+       ea->broadcast_enabled = broadcast_enabled;
 
        mlx5e_vport_context_update(priv);
 }
@@ -877,217 +525,446 @@ static void mlx5e_destroy_groups(struct mlx5e_flow_table *ft)
        ft->num_groups = 0;
 }
 
-void mlx5e_init_eth_addr(struct mlx5e_priv *priv)
+void mlx5e_init_l2_addr(struct mlx5e_priv *priv)
 {
-       ether_addr_copy(priv->fs.main.broadcast.addr, priv->netdev->broadcast);
+       ether_addr_copy(priv->fs.l2.broadcast.addr, priv->netdev->broadcast);
 }
 
-#define MLX5E_MAIN_GROUP0_SIZE BIT(3)
-#define MLX5E_MAIN_GROUP1_SIZE BIT(1)
-#define MLX5E_MAIN_GROUP2_SIZE BIT(0)
-#define MLX5E_MAIN_GROUP3_SIZE BIT(14)
-#define MLX5E_MAIN_GROUP4_SIZE BIT(13)
-#define MLX5E_MAIN_GROUP5_SIZE BIT(11)
-#define MLX5E_MAIN_GROUP6_SIZE BIT(2)
-#define MLX5E_MAIN_GROUP7_SIZE BIT(1)
-#define MLX5E_MAIN_GROUP8_SIZE BIT(0)
-#define MLX5E_MAIN_TABLE_SIZE  (MLX5E_MAIN_GROUP0_SIZE +\
-                                MLX5E_MAIN_GROUP1_SIZE +\
-                                MLX5E_MAIN_GROUP2_SIZE +\
-                                MLX5E_MAIN_GROUP3_SIZE +\
-                                MLX5E_MAIN_GROUP4_SIZE +\
-                                MLX5E_MAIN_GROUP5_SIZE +\
-                                MLX5E_MAIN_GROUP6_SIZE +\
-                                MLX5E_MAIN_GROUP7_SIZE +\
-                                MLX5E_MAIN_GROUP8_SIZE)
-
-static int __mlx5e_create_main_table_groups(struct mlx5e_flow_table *ft, u32 *in,
-                                           int inlen)
+static void mlx5e_destroy_flow_table(struct mlx5e_flow_table *ft)
 {
-       u8 *mc = MLX5_ADDR_OF(create_flow_group_in, in, match_criteria);
-       u8 *dmac = MLX5_ADDR_OF(create_flow_group_in, in,
-                               match_criteria.outer_headers.dmac_47_16);
+       mlx5e_destroy_groups(ft);
+       kfree(ft->g);
+       mlx5_destroy_flow_table(ft->t);
+       ft->t = NULL;
+}
+
+static void mlx5e_cleanup_ttc_rules(struct mlx5e_ttc_table *ttc)
+{
+       int i;
+
+       for (i = 0; i < MLX5E_NUM_TT; i++) {
+               if (!IS_ERR_OR_NULL(ttc->rules[i])) {
+                       mlx5_del_flow_rule(ttc->rules[i]);
+                       ttc->rules[i] = NULL;
+               }
+       }
+}
+
+static struct {
+       u16 etype;
+       u8 proto;
+} ttc_rules[] = {
+       [MLX5E_TT_IPV4_TCP] = {
+               .etype = ETH_P_IP,
+               .proto = IPPROTO_TCP,
+       },
+       [MLX5E_TT_IPV6_TCP] = {
+               .etype = ETH_P_IPV6,
+               .proto = IPPROTO_TCP,
+       },
+       [MLX5E_TT_IPV4_UDP] = {
+               .etype = ETH_P_IP,
+               .proto = IPPROTO_UDP,
+       },
+       [MLX5E_TT_IPV6_UDP] = {
+               .etype = ETH_P_IPV6,
+               .proto = IPPROTO_UDP,
+       },
+       [MLX5E_TT_IPV4_IPSEC_AH] = {
+               .etype = ETH_P_IP,
+               .proto = IPPROTO_AH,
+       },
+       [MLX5E_TT_IPV6_IPSEC_AH] = {
+               .etype = ETH_P_IPV6,
+               .proto = IPPROTO_AH,
+       },
+       [MLX5E_TT_IPV4_IPSEC_ESP] = {
+               .etype = ETH_P_IP,
+               .proto = IPPROTO_ESP,
+       },
+       [MLX5E_TT_IPV6_IPSEC_ESP] = {
+               .etype = ETH_P_IPV6,
+               .proto = IPPROTO_ESP,
+       },
+       [MLX5E_TT_IPV4] = {
+               .etype = ETH_P_IP,
+               .proto = 0,
+       },
+       [MLX5E_TT_IPV6] = {
+               .etype = ETH_P_IPV6,
+               .proto = 0,
+       },
+       [MLX5E_TT_ANY] = {
+               .etype = 0,
+               .proto = 0,
+       },
+};
+
+static struct mlx5_flow_rule *mlx5e_generate_ttc_rule(struct mlx5e_priv *priv,
+                                                     struct mlx5_flow_table *ft,
+                                                     struct mlx5_flow_destination *dest,
+                                                     u16 etype,
+                                                     u8 proto)
+{
+       struct mlx5_flow_rule *rule;
+       u8 match_criteria_enable = 0;
+       u32 *match_criteria;
+       u32 *match_value;
+       int err = 0;
+
+       match_value     = mlx5_vzalloc(MLX5_ST_SZ_BYTES(fte_match_param));
+       match_criteria  = mlx5_vzalloc(MLX5_ST_SZ_BYTES(fte_match_param));
+       if (!match_value || !match_criteria) {
+               netdev_err(priv->netdev, "%s: alloc failed\n", __func__);
+               err = -ENOMEM;
+               goto out;
+       }
+
+       if (proto) {
+               match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;
+               MLX5_SET_TO_ONES(fte_match_param, match_criteria, outer_headers.ip_protocol);
+               MLX5_SET(fte_match_param, match_value, outer_headers.ip_protocol, proto);
+       }
+       if (etype) {
+               match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;
+               MLX5_SET_TO_ONES(fte_match_param, match_criteria, outer_headers.ethertype);
+               MLX5_SET(fte_match_param, match_value, outer_headers.ethertype, etype);
+       }
+
+       rule = mlx5_add_flow_rule(ft, match_criteria_enable,
+                                 match_criteria, match_value,
+                                 MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
+                                 MLX5_FS_DEFAULT_FLOW_TAG,
+                                 dest);
+       if (IS_ERR(rule)) {
+               err = PTR_ERR(rule);
+               netdev_err(priv->netdev, "%s: add rule failed\n", __func__);
+       }
+out:
+       kvfree(match_criteria);
+       kvfree(match_value);
+       return err ? ERR_PTR(err) : rule;
+}
+
+static int mlx5e_generate_ttc_table_rules(struct mlx5e_priv *priv)
+{
+       struct mlx5_flow_destination dest;
+       struct mlx5e_ttc_table *ttc;
+       struct mlx5_flow_rule **rules;
+       struct mlx5_flow_table *ft;
+       int tt;
        int err;
+
+       ttc = &priv->fs.ttc;
+       ft = ttc->ft.t;
+       rules = ttc->rules;
+
+       dest.type = MLX5_FLOW_DESTINATION_TYPE_TIR;
+       for (tt = 0; tt < MLX5E_NUM_TT; tt++) {
+               if (tt == MLX5E_TT_ANY)
+                       dest.tir_num = priv->direct_tir[0].tirn;
+               else
+                       dest.tir_num = priv->indir_tirn[tt];
+               rules[tt] = mlx5e_generate_ttc_rule(priv, ft, &dest,
+                                                   ttc_rules[tt].etype,
+                                                   ttc_rules[tt].proto);
+               if (IS_ERR(rules[tt]))
+                       goto del_rules;
+       }
+
+       return 0;
+
+del_rules:
+       err = PTR_ERR(rules[tt]);
+       rules[tt] = NULL;
+       mlx5e_cleanup_ttc_rules(ttc);
+       return err;
+}
+
+#define MLX5E_TTC_NUM_GROUPS   3
+#define MLX5E_TTC_GROUP1_SIZE  BIT(3)
+#define MLX5E_TTC_GROUP2_SIZE  BIT(1)
+#define MLX5E_TTC_GROUP3_SIZE  BIT(0)
+#define MLX5E_TTC_TABLE_SIZE   (MLX5E_TTC_GROUP1_SIZE +\
+                                MLX5E_TTC_GROUP2_SIZE +\
+                                MLX5E_TTC_GROUP3_SIZE)
+static int mlx5e_create_ttc_table_groups(struct mlx5e_ttc_table *ttc)
+{
+       int inlen = MLX5_ST_SZ_BYTES(create_flow_group_in);
+       struct mlx5e_flow_table *ft = &ttc->ft;
        int ix = 0;
+       u32 *in;
+       int err;
+       u8 *mc;
 
-       memset(in, 0, inlen);
-       MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ethertype);
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ip_protocol);
-       MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP0_SIZE;
-       MLX5_SET_CFG(in, end_flow_index, ix - 1);
-       ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
-       if (IS_ERR(ft->g[ft->num_groups]))
-               goto err_destroy_groups;
-       ft->num_groups++;
+       ft->g = kcalloc(MLX5E_TTC_NUM_GROUPS,
+                       sizeof(*ft->g), GFP_KERNEL);
+       if (!ft->g)
+               return -ENOMEM;
+       in = mlx5_vzalloc(inlen);
+       if (!in) {
+               kfree(ft->g);
+               return -ENOMEM;
+       }
 
-       memset(in, 0, inlen);
-       MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
+       /* L4 Group */
+       mc = MLX5_ADDR_OF(create_flow_group_in, in, match_criteria);
+       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ip_protocol);
        MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ethertype);
+       MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
        MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP1_SIZE;
+       ix += MLX5E_TTC_GROUP1_SIZE;
        MLX5_SET_CFG(in, end_flow_index, ix - 1);
        ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
        if (IS_ERR(ft->g[ft->num_groups]))
-               goto err_destroy_groups;
+               goto err;
        ft->num_groups++;
 
-       memset(in, 0, inlen);
+       /* L3 Group */
+       MLX5_SET(fte_match_param, mc, outer_headers.ip_protocol, 0);
        MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP2_SIZE;
+       ix += MLX5E_TTC_GROUP2_SIZE;
        MLX5_SET_CFG(in, end_flow_index, ix - 1);
        ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
        if (IS_ERR(ft->g[ft->num_groups]))
-               goto err_destroy_groups;
+               goto err;
        ft->num_groups++;
 
+       /* Any Group */
        memset(in, 0, inlen);
-       MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ethertype);
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ip_protocol);
-       eth_broadcast_addr(dmac);
        MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP3_SIZE;
+       ix += MLX5E_TTC_GROUP3_SIZE;
        MLX5_SET_CFG(in, end_flow_index, ix - 1);
        ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
        if (IS_ERR(ft->g[ft->num_groups]))
-               goto err_destroy_groups;
+               goto err;
        ft->num_groups++;
 
-       memset(in, 0, inlen);
-       MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ethertype);
-       eth_broadcast_addr(dmac);
-       MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP4_SIZE;
-       MLX5_SET_CFG(in, end_flow_index, ix - 1);
-       ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
-       if (IS_ERR(ft->g[ft->num_groups]))
-               goto err_destroy_groups;
-       ft->num_groups++;
+       kvfree(in);
+       return 0;
 
-       memset(in, 0, inlen);
-       MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
-       eth_broadcast_addr(dmac);
-       MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP5_SIZE;
-       MLX5_SET_CFG(in, end_flow_index, ix - 1);
-       ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
-       if (IS_ERR(ft->g[ft->num_groups]))
-               goto err_destroy_groups;
-       ft->num_groups++;
+err:
+       err = PTR_ERR(ft->g[ft->num_groups]);
+       ft->g[ft->num_groups] = NULL;
+       kvfree(in);
 
-       memset(in, 0, inlen);
-       MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ethertype);
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ip_protocol);
-       dmac[0] = 0x01;
+       return err;
+}
+
+static void mlx5e_destroy_ttc_table(struct mlx5e_priv *priv)
+{
+       struct mlx5e_ttc_table *ttc = &priv->fs.ttc;
+
+       mlx5e_cleanup_ttc_rules(ttc);
+       mlx5e_destroy_flow_table(&ttc->ft);
+}
+
+static int mlx5e_create_ttc_table(struct mlx5e_priv *priv)
+{
+       struct mlx5e_ttc_table *ttc = &priv->fs.ttc;
+       struct mlx5e_flow_table *ft = &ttc->ft;
+       int err;
+
+       ft->t = mlx5_create_flow_table(priv->fs.ns, MLX5E_NIC_PRIO,
+                                      MLX5E_TTC_TABLE_SIZE, MLX5E_TTC_FT_LEVEL);
+       if (IS_ERR(ft->t)) {
+               err = PTR_ERR(ft->t);
+               ft->t = NULL;
+               return err;
+       }
+
+       err = mlx5e_create_ttc_table_groups(ttc);
+       if (err)
+               goto err;
+
+       err = mlx5e_generate_ttc_table_rules(priv);
+       if (err)
+               goto err;
+
+       return 0;
+err:
+       mlx5e_destroy_flow_table(ft);
+       return err;
+}
+
+static void mlx5e_del_l2_flow_rule(struct mlx5e_priv *priv,
+                                  struct mlx5e_l2_rule *ai)
+{
+       if (!IS_ERR_OR_NULL(ai->rule)) {
+               mlx5_del_flow_rule(ai->rule);
+               ai->rule = NULL;
+       }
+}
+
+static int mlx5e_add_l2_flow_rule(struct mlx5e_priv *priv,
+                                 struct mlx5e_l2_rule *ai, int type)
+{
+       struct mlx5_flow_table *ft = priv->fs.l2.ft.t;
+       struct mlx5_flow_destination dest;
+       u8 match_criteria_enable = 0;
+       u32 *match_criteria;
+       u32 *match_value;
+       int err = 0;
+       u8 *mc_dmac;
+       u8 *mv_dmac;
+
+       match_value    = mlx5_vzalloc(MLX5_ST_SZ_BYTES(fte_match_param));
+       match_criteria = mlx5_vzalloc(MLX5_ST_SZ_BYTES(fte_match_param));
+       if (!match_value || !match_criteria) {
+               netdev_err(priv->netdev, "%s: alloc failed\n", __func__);
+               err = -ENOMEM;
+               goto add_l2_rule_out;
+       }
+
+       mc_dmac = MLX5_ADDR_OF(fte_match_param, match_criteria,
+                              outer_headers.dmac_47_16);
+       mv_dmac = MLX5_ADDR_OF(fte_match_param, match_value,
+                              outer_headers.dmac_47_16);
+
+       dest.type = MLX5_FLOW_DESTINATION_TYPE_FLOW_TABLE;
+       dest.ft = priv->fs.ttc.ft.t;
+
+       switch (type) {
+       case MLX5E_FULLMATCH:
+               match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;
+               eth_broadcast_addr(mc_dmac);
+               ether_addr_copy(mv_dmac, ai->addr);
+               break;
+
+       case MLX5E_ALLMULTI:
+               match_criteria_enable = MLX5_MATCH_OUTER_HEADERS;
+               mc_dmac[0] = 0x01;
+               mv_dmac[0] = 0x01;
+               break;
+
+       case MLX5E_PROMISC:
+               break;
+       }
+
+       ai->rule = mlx5_add_flow_rule(ft, match_criteria_enable, match_criteria,
+                                     match_value,
+                                     MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
+                                     MLX5_FS_DEFAULT_FLOW_TAG, &dest);
+       if (IS_ERR(ai->rule)) {
+               netdev_err(priv->netdev, "%s: add l2 rule(mac:%pM) failed\n",
+                          __func__, mv_dmac);
+               err = PTR_ERR(ai->rule);
+               ai->rule = NULL;
+       }
+
+add_l2_rule_out:
+       kvfree(match_criteria);
+       kvfree(match_value);
+
+       return err;
+}
+
+#define MLX5E_NUM_L2_GROUPS       3
+#define MLX5E_L2_GROUP1_SIZE      BIT(0)
+#define MLX5E_L2_GROUP2_SIZE      BIT(15)
+#define MLX5E_L2_GROUP3_SIZE      BIT(0)
+#define MLX5E_L2_TABLE_SIZE       (MLX5E_L2_GROUP1_SIZE +\
+                                   MLX5E_L2_GROUP2_SIZE +\
+                                   MLX5E_L2_GROUP3_SIZE)
+static int mlx5e_create_l2_table_groups(struct mlx5e_l2_table *l2_table)
+{
+       int inlen = MLX5_ST_SZ_BYTES(create_flow_group_in);
+       struct mlx5e_flow_table *ft = &l2_table->ft;
+       int ix = 0;
+       u8 *mc_dmac;
+       u32 *in;
+       int err;
+       u8 *mc;
+
+       ft->g = kcalloc(MLX5E_NUM_L2_GROUPS, sizeof(*ft->g), GFP_KERNEL);
+       if (!ft->g)
+               return -ENOMEM;
+       in = mlx5_vzalloc(inlen);
+       if (!in) {
+               kfree(ft->g);
+               return -ENOMEM;
+       }
+
+       mc = MLX5_ADDR_OF(create_flow_group_in, in, match_criteria);
+       mc_dmac = MLX5_ADDR_OF(fte_match_param, mc,
+                              outer_headers.dmac_47_16);
+       /* Flow Group for promiscuous */
        MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP6_SIZE;
+       ix += MLX5E_L2_GROUP1_SIZE;
        MLX5_SET_CFG(in, end_flow_index, ix - 1);
        ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
        if (IS_ERR(ft->g[ft->num_groups]))
                goto err_destroy_groups;
        ft->num_groups++;
 
-       memset(in, 0, inlen);
+       /* Flow Group for full match */
+       eth_broadcast_addr(mc_dmac);
        MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
-       MLX5_SET_TO_ONES(fte_match_param, mc, outer_headers.ethertype);
-       dmac[0] = 0x01;
        MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP7_SIZE;
+       ix += MLX5E_L2_GROUP2_SIZE;
        MLX5_SET_CFG(in, end_flow_index, ix - 1);
        ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
        if (IS_ERR(ft->g[ft->num_groups]))
                goto err_destroy_groups;
        ft->num_groups++;
 
-       memset(in, 0, inlen);
-       MLX5_SET_CFG(in, match_criteria_enable, MLX5_MATCH_OUTER_HEADERS);
-       dmac[0] = 0x01;
+       /* Flow Group for allmulti */
+       eth_zero_addr(mc_dmac);
+       mc_dmac[0] = 0x01;
        MLX5_SET_CFG(in, start_flow_index, ix);
-       ix += MLX5E_MAIN_GROUP8_SIZE;
+       ix += MLX5E_L2_GROUP3_SIZE;
        MLX5_SET_CFG(in, end_flow_index, ix - 1);
        ft->g[ft->num_groups] = mlx5_create_flow_group(ft->t, in);
        if (IS_ERR(ft->g[ft->num_groups]))
                goto err_destroy_groups;
        ft->num_groups++;
 
+       kvfree(in);
        return 0;
 
 err_destroy_groups:
        err = PTR_ERR(ft->g[ft->num_groups]);
        ft->g[ft->num_groups] = NULL;
        mlx5e_destroy_groups(ft);
+       kvfree(in);
 
        return err;
 }
 
-static int mlx5e_create_main_table_groups(struct mlx5e_flow_table *ft)
+static void mlx5e_destroy_l2_table(struct mlx5e_priv *priv)
 {
-       u32 *in;
-       int inlen = MLX5_ST_SZ_BYTES(create_flow_group_in);
-       int err;
-
-       in = mlx5_vzalloc(inlen);
-       if (!in)
-               return -ENOMEM;
-
-       err = __mlx5e_create_main_table_groups(ft, in, inlen);
-
-       kvfree(in);
-       return err;
+       mlx5e_destroy_flow_table(&priv->fs.l2.ft);
 }
 
-static int mlx5e_create_main_table(struct mlx5e_priv *priv)
+static int mlx5e_create_l2_table(struct mlx5e_priv *priv)
 {
-       struct mlx5e_flow_table *ft = &priv->fs.main.ft;
+       struct mlx5e_l2_table *l2_table = &priv->fs.l2;
+       struct mlx5e_flow_table *ft = &l2_table->ft;
        int err;
 
        ft->num_groups = 0;
        ft->t = mlx5_create_flow_table(priv->fs.ns, MLX5E_NIC_PRIO,
-                                      MLX5E_MAIN_TABLE_SIZE, MLX5E_MAIN_FT_LEVEL);
+                                      MLX5E_L2_TABLE_SIZE, MLX5E_L2_FT_LEVEL);
 
        if (IS_ERR(ft->t)) {
                err = PTR_ERR(ft->t);
                ft->t = NULL;
                return err;
        }
-       ft->g = kcalloc(MLX5E_NUM_MAIN_GROUPS, sizeof(*ft->g), GFP_KERNEL);
-       if (!ft->g) {
-               err = -ENOMEM;
-               goto err_destroy_main_table;
-       }
 
-       err = mlx5e_create_main_table_groups(ft);
+       err = mlx5e_create_l2_table_groups(l2_table);
        if (err)
-               goto err_free_g;
-       return 0;
+               goto err_destroy_flow_table;
 
-err_free_g:
-       kfree(ft->g);
+       return 0;
 
-err_destroy_main_table:
+err_destroy_flow_table:
        mlx5_destroy_flow_table(ft->t);
        ft->t = NULL;
 
        return err;
 }
 
-static void mlx5e_destroy_flow_table(struct mlx5e_flow_table *ft)
-{
-       mlx5e_destroy_groups(ft);
-       kfree(ft->g);
-       mlx5_destroy_flow_table(ft->t);
-       ft->t = NULL;
-}
-
-static void mlx5e_destroy_main_table(struct mlx5e_priv *priv)
-{
-       mlx5e_destroy_flow_table(&priv->fs.main.ft);
-}
-
 #define MLX5E_NUM_VLAN_GROUPS  2
 #define MLX5E_VLAN_GROUP0_SIZE BIT(12)
 #define MLX5E_VLAN_GROUP1_SIZE BIT(1)
@@ -1206,18 +1083,33 @@ int mlx5e_create_flow_steering(struct mlx5e_priv *priv)
        if (!priv->fs.ns)
                return -EINVAL;
 
-       err = mlx5e_create_main_table(priv);
-       if (err)
+       err = mlx5e_create_ttc_table(priv);
+       if (err) {
+               netdev_err(priv->netdev, "Failed to create ttc table, err=%d\n",
+                          err);
                return err;
+       }
+
+       err = mlx5e_create_l2_table(priv);
+       if (err) {
+               netdev_err(priv->netdev, "Failed to create l2 table, err=%d\n",
+                          err);
+               goto err_destroy_ttc_table;
+       }
 
        err = mlx5e_create_vlan_table(priv);
-       if (err)
-               goto err_destroy_main_table;
+       if (err) {
+               netdev_err(priv->netdev, "Failed to create vlan table, err=%d\n",
+                          err);
+               goto err_destroy_l2_table;
+       }
 
        return 0;
 
-err_destroy_main_table:
-       mlx5e_destroy_main_table(priv);
+err_destroy_l2_table:
+       mlx5e_destroy_l2_table(priv);
+err_destroy_ttc_table:
+       mlx5e_destroy_ttc_table(priv);
 
        return err;
 }
@@ -1226,5 +1118,6 @@ void mlx5e_destroy_flow_steering(struct mlx5e_priv *priv)
 {
        mlx5e_del_vlan_rule(priv, MLX5E_VLAN_RULE_TYPE_UNTAGGED, 0);
        mlx5e_destroy_vlan_table(priv);
-       mlx5e_destroy_main_table(priv);
+       mlx5e_destroy_l2_table(priv);
+       mlx5e_destroy_ttc_table(priv);
 }