Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
[cascardo/linux.git] / net / core / flow_dissector.c
index 52742a0..1a7b80f 100644 (file)
@@ -6,6 +6,8 @@
 #include <linux/if_vlan.h>
 #include <net/ip.h>
 #include <net/ipv6.h>
+#include <net/gre.h>
+#include <net/pptp.h>
 #include <linux/igmp.h>
 #include <linux/icmp.h>
 #include <linux/sctp.h>
@@ -116,13 +118,16 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
        struct flow_dissector_key_addrs *key_addrs;
        struct flow_dissector_key_ports *key_ports;
        struct flow_dissector_key_tags *key_tags;
+       struct flow_dissector_key_vlan *key_vlan;
        struct flow_dissector_key_keyid *key_keyid;
+       bool skip_vlan = false;
        u8 ip_proto = 0;
        bool ret = false;
 
        if (!data) {
                data = skb->data;
-               proto = skb->protocol;
+               proto = skb_vlan_tag_present(skb) ?
+                        skb->vlan_proto : skb->protocol;
                nhoff = skb_network_offset(skb);
                hlen = skb_headlen(skb);
        }
@@ -241,23 +246,45 @@ ipv6:
        case htons(ETH_P_8021AD):
        case htons(ETH_P_8021Q): {
                const struct vlan_hdr *vlan;
-               struct vlan_hdr _vlan;
 
-               vlan = __skb_header_pointer(skb, nhoff, sizeof(_vlan), data, hlen, &_vlan);
-               if (!vlan)
-                       goto out_bad;
+               if (skb_vlan_tag_present(skb))
+                       proto = skb->protocol;
+
+               if (!skb_vlan_tag_present(skb) ||
+                   proto == cpu_to_be16(ETH_P_8021Q) ||
+                   proto == cpu_to_be16(ETH_P_8021AD)) {
+                       struct vlan_hdr _vlan;
 
+                       vlan = __skb_header_pointer(skb, nhoff, sizeof(_vlan),
+                                                   data, hlen, &_vlan);
+                       if (!vlan)
+                               goto out_bad;
+                       proto = vlan->h_vlan_encapsulated_proto;
+                       nhoff += sizeof(*vlan);
+                       if (skip_vlan)
+                               goto again;
+               }
+
+               skip_vlan = true;
                if (dissector_uses_key(flow_dissector,
-                                      FLOW_DISSECTOR_KEY_VLANID)) {
-                       key_tags = skb_flow_dissector_target(flow_dissector,
-                                                            FLOW_DISSECTOR_KEY_VLANID,
+                                      FLOW_DISSECTOR_KEY_VLAN)) {
+                       key_vlan = skb_flow_dissector_target(flow_dissector,
+                                                            FLOW_DISSECTOR_KEY_VLAN,
                                                             target_container);
 
-                       key_tags->vlan_id = skb_vlan_tag_get_id(skb);
+                       if (skb_vlan_tag_present(skb)) {
+                               key_vlan->vlan_id = skb_vlan_tag_get_id(skb);
+                               key_vlan->vlan_priority =
+                                       (skb_vlan_tag_get_prio(skb) >> VLAN_PRIO_SHIFT);
+                       } else {
+                               key_vlan->vlan_id = ntohs(vlan->h_vlan_TCI) &
+                                       VLAN_VID_MASK;
+                               key_vlan->vlan_priority =
+                                       (ntohs(vlan->h_vlan_TCI) &
+                                        VLAN_PRIO_MASK) >> VLAN_PRIO_SHIFT;
+                       }
                }
 
-               proto = vlan->h_vlan_encapsulated_proto;
-               nhoff += sizeof(*vlan);
                goto again;
        }
        case htons(ETH_P_PPP_SES): {
@@ -338,32 +365,42 @@ mpls:
 ip_proto_again:
        switch (ip_proto) {
        case IPPROTO_GRE: {
-               struct gre_hdr {
-                       __be16 flags;
-                       __be16 proto;
-               } *hdr, _hdr;
+               struct gre_base_hdr *hdr, _hdr;
+               u16 gre_ver;
+               int offset = 0;
 
                hdr = __skb_header_pointer(skb, nhoff, sizeof(_hdr), data, hlen, &_hdr);
                if (!hdr)
                        goto out_bad;
-               /*
-                * Only look inside GRE if version zero and no
-                * routing
-                */
-               if (hdr->flags & (GRE_VERSION | GRE_ROUTING))
+
+               /* Only look inside GRE without routing */
+               if (hdr->flags & GRE_ROUTING)
                        break;
 
-               proto = hdr->proto;
-               nhoff += 4;
+               /* Only look inside GRE for version 0 and 1 */
+               gre_ver = ntohs(hdr->flags & GRE_VERSION);
+               if (gre_ver > 1)
+                       break;
+
+               proto = hdr->protocol;
+               if (gre_ver) {
+                       /* Version1 must be PPTP, and check the flags */
+                       if (!(proto == GRE_PROTO_PPP && (hdr->flags & GRE_KEY)))
+                               break;
+               }
+
+               offset += sizeof(struct gre_base_hdr);
+
                if (hdr->flags & GRE_CSUM)
-                       nhoff += 4;
+                       offset += sizeof(((struct gre_full_hdr *)0)->csum) +
+                                 sizeof(((struct gre_full_hdr *)0)->reserved1);
+
                if (hdr->flags & GRE_KEY) {
                        const __be32 *keyid;
                        __be32 _keyid;
 
-                       keyid = __skb_header_pointer(skb, nhoff, sizeof(_keyid),
+                       keyid = __skb_header_pointer(skb, nhoff + offset, sizeof(_keyid),
                                                     data, hlen, &_keyid);
-
                        if (!keyid)
                                goto out_bad;
 
@@ -372,32 +409,65 @@ ip_proto_again:
                                key_keyid = skb_flow_dissector_target(flow_dissector,
                                                                      FLOW_DISSECTOR_KEY_GRE_KEYID,
                                                                      target_container);
-                               key_keyid->keyid = *keyid;
+                               if (gre_ver == 0)
+                                       key_keyid->keyid = *keyid;
+                               else
+                                       key_keyid->keyid = *keyid & GRE_PPTP_KEY_MASK;
                        }
-                       nhoff += 4;
+                       offset += sizeof(((struct gre_full_hdr *)0)->key);
                }
+
                if (hdr->flags & GRE_SEQ)
-                       nhoff += 4;
-               if (proto == htons(ETH_P_TEB)) {
-                       const struct ethhdr *eth;
-                       struct ethhdr _eth;
-
-                       eth = __skb_header_pointer(skb, nhoff,
-                                                  sizeof(_eth),
-                                                  data, hlen, &_eth);
-                       if (!eth)
+                       offset += sizeof(((struct pptp_gre_header *)0)->seq);
+
+               if (gre_ver == 0) {
+                       if (proto == htons(ETH_P_TEB)) {
+                               const struct ethhdr *eth;
+                               struct ethhdr _eth;
+
+                               eth = __skb_header_pointer(skb, nhoff + offset,
+                                                          sizeof(_eth),
+                                                          data, hlen, &_eth);
+                               if (!eth)
+                                       goto out_bad;
+                               proto = eth->h_proto;
+                               offset += sizeof(*eth);
+
+                               /* Cap headers that we access via pointers at the
+                                * end of the Ethernet header as our maximum alignment
+                                * at that point is only 2 bytes.
+                                */
+                               if (NET_IP_ALIGN)
+                                       hlen = (nhoff + offset);
+                       }
+               } else { /* version 1, must be PPTP */
+                       u8 _ppp_hdr[PPP_HDRLEN];
+                       u8 *ppp_hdr;
+
+                       if (hdr->flags & GRE_ACK)
+                               offset += sizeof(((struct pptp_gre_header *)0)->ack);
+
+                       ppp_hdr = skb_header_pointer(skb, nhoff + offset,
+                                                    sizeof(_ppp_hdr), _ppp_hdr);
+                       if (!ppp_hdr)
                                goto out_bad;
-                       proto = eth->h_proto;
-                       nhoff += sizeof(*eth);
-
-                       /* Cap headers that we access via pointers at the
-                        * end of the Ethernet header as our maximum alignment
-                        * at that point is only 2 bytes.
-                        */
-                       if (NET_IP_ALIGN)
-                               hlen = nhoff;
+
+                       switch (PPP_PROTOCOL(ppp_hdr)) {
+                       case PPP_IP:
+                               proto = htons(ETH_P_IP);
+                               break;
+                       case PPP_IPV6:
+                               proto = htons(ETH_P_IPV6);
+                               break;
+                       default:
+                               /* Could probably catch some more like MPLS */
+                               break;
+                       }
+
+                       offset += PPP_HDRLEN;
                }
 
+               nhoff += offset;
                key_control->flags |= FLOW_DIS_ENCAPSULATION;
                if (flags & FLOW_DISSECTOR_F_STOP_AT_ENCAP)
                        goto out_good;
@@ -874,8 +944,8 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = {
                .offset = offsetof(struct flow_keys, ports),
        },
        {
-               .key_id = FLOW_DISSECTOR_KEY_VLANID,
-               .offset = offsetof(struct flow_keys, tags),
+               .key_id = FLOW_DISSECTOR_KEY_VLAN,
+               .offset = offsetof(struct flow_keys, vlan),
        },
        {
                .key_id = FLOW_DISSECTOR_KEY_FLOW_LABEL,