net: fix __netdev_update_features return on ndo_set_features failure
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Fri, 13 Nov 2015 14:20:24 +0000 (15:20 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Nov 2015 19:56:03 +0000 (14:56 -0500)
commit00ee5927177792a6e139d50b6b7564d35705556a
tree51d79c6a16b5ad9280d1bca48db4cc91d0ecbec2
parent5f8dc33e8ee7e59bee3bc6dc2088807a384b285a
net: fix __netdev_update_features return on ndo_set_features failure

If ndo_set_features fails __netdev_update_features() will return -1 but
this is wrong because it is expected to return 0 if no features were
changed (see netdev_update_features()), which will cause a netdev
notifier to be called without any actual changes. Fix this by returning
0 if ndo_set_features fails.

Fixes: 6cb6a27c45ce ("net: Call netdev_features_change() from netdev_update_features()")
CC: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c