Revert "ipv4/icmp: redirect messages can use the ingress daddr as source"
authorPaolo Abeni <pabeni@redhat.com>
Wed, 14 Oct 2015 12:25:53 +0000 (14:25 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Oct 2015 13:01:07 +0000 (06:01 -0700)
commit02a6d6136fa2a17f400a030829a6435556b3e65b
tree1f07c6a39405a3e650f5e6b48b0cf68ae9adefdc
parent7d1f6411b04fef2f0a260205c92e811b280ae117
Revert "ipv4/icmp: redirect messages can use the ingress daddr as source"

Revert the commit e2ca690b657f ("ipv4/icmp: redirect messages
can use the ingress daddr as source"), which tried to introduce a more
suitable behaviour for ICMP redirect messages generated by VRRP routers.
However RFC 5798 section 8.1.1 states:

    The IPv4 source address of an ICMP redirect should be the address
    that the end-host used when making its next-hop routing decision.

while said commit used the generating packet destination
address, which do not match the above and in most cases leads to
no redirect packets to be generated.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/networking/ip-sysctl.txt
include/net/netns/ipv4.h
net/ipv4/icmp.c
net/ipv4/sysctl_net_ipv4.c