mtd: spi-nor: fix wrong "fully unlocked" test
authorBrian Norris <computersforpeace@gmail.com>
Fri, 24 Jun 2016 17:38:14 +0000 (10:38 -0700)
committerBrian Norris <computersforpeace@gmail.com>
Sun, 10 Jul 2016 02:29:38 +0000 (19:29 -0700)
commit06586204714b7befec99e554c71687b0b40f351c
treea9b3b4af144f225b85e44567eebe7342e6d095ff
parent21a190b970878be8298c3f696aede1de36986817
mtd: spi-nor: fix wrong "fully unlocked" test

In stm_unlock(), the test to determine whether we've fully unlocked the
flash checks for the lock length to be equal to the flash size. That is
a typo/think-o -- the condition actually means the flash is completely
*locked.* We should be using the inverse condition -- that the lock
length is 0 (i.e., no protection).

The result of this bug is that we never actually turn off the Status
Register Write Disable bit, even if the flash is completely unlocked.
Now we can.

Fixes: 47b8edbf0d43 ("mtd: spi-nor: disallow further writes to SR if WP# is low")
Reported-by: Giorgio <giorgio.nicole@arcor.de>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
drivers/mtd/spi-nor/spi-nor.c