cgroup: fix umount vs cgroup_cfts_commit() race
authorLi Zefan <lizefan@huawei.com>
Tue, 18 Jun 2013 10:40:19 +0000 (18:40 +0800)
committerTejun Heo <tj@kernel.org>
Tue, 18 Jun 2013 16:04:30 +0000 (09:04 -0700)
commit084457f284abf6789d90509ee11dae383842b23b
tree6e401afe9c5d2b84b4d8a1877f72496b3931448d
parent6db8e85c5c1f89cd0183b76dab027c81009f129f
cgroup: fix umount vs cgroup_cfts_commit() race

cgroup_cfts_commit() uses dget() to keep cgroup alive after cgroup_mutex
is dropped, but dget() won't prevent cgroupfs from being umounted. When
the race happens, vfs will see some dentries with non-zero refcnt while
umount is in process.

Keep running this:
  mount -t cgroup -o blkio xxx /cgroup
  umount /cgroup

And this:
  modprobe cfq-iosched
  rmmod cfs-iosched

After a while, the BUG() in shrink_dcache_for_umount_subtree() may
be triggered:

  BUG: Dentry xxx{i=0,n=blkio.yyy} still in use (1) [umount of cgroup cgroup]

Signed-off-by: Li Zefan <lizefan@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org
kernel/cgroup.c