efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver
authorIngo Molnar <mingo@kernel.org>
Fri, 29 Apr 2016 08:31:28 +0000 (10:31 +0200)
committerIngo Molnar <mingo@kernel.org>
Fri, 29 Apr 2016 09:06:15 +0000 (11:06 +0200)
commit0ec7ae928a9c19c2b7b8054507d5694a2597065e
treecd8845fc685a9994124ee3b7aa60ebc1324f61f8
parent0cf0223c8370af0fcedb15a408d3c17bb4b9e21d
efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver

So the following commit:

  884f4f66ffd6 ("efi: Remove global 'memmap' EFI memory map")

... triggered the following build warning on x86 64-bit allyesconfig:

drivers/xen/efi.c:290:47: warning: missing braces around initializer [-Wmissing-braces]

It's this initialization in drivers/xen/efi.c:

  static const struct efi efi_xen __initconst = {
  ...
        .memmap                   = NULL, /* Not used under Xen. */
  ...

which was forgotten about, as .memmap now is an embedded struct:

        struct efi_memory_map memmap;

We can remove this initialization - it's an EFI core internal data structure plus
it's not used in the Xen driver anyway.

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: ard.biesheuvel@linaro.org
Cc: bp@alien8.de
Cc: linux-tip-commits@vger.kernel.org
Cc: tony.luck@intel.com
Link: http://lkml.kernel.org/r/20160429083128.GA4925@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
drivers/xen/efi.c