xfs: fix up inode32/64 (re)mount handling
authorEric Sandeen <sandeen@redhat.com>
Tue, 1 Mar 2016 22:58:09 +0000 (09:58 +1100)
committerDave Chinner <david@fromorbit.com>
Tue, 1 Mar 2016 22:58:09 +0000 (09:58 +1100)
commit12c3f05c7b592ae3bf2219392f1cbf252645cd79
tree84d13db49ec7de70cee1ae873c3f05e9e89b3fe2
parent5d518bd6cec6f921ee1be504094762496afb45fb
xfs: fix up inode32/64 (re)mount handling

inode32/inode64 allocator behavior with respect to mount, remount
and growfs is a little tricky.

The inode32 mount option should only enable the inode32 allocator
heuristics if the filesystem is large enough for 64-bit inodes to
exist.  Today, it has this behavior on the initial mount, but a
remount with inode32 unconditionally changes the allocation
heuristics, even for a small fs.

Also, an inode32 mounted small filesystem should transition to the
inode32 allocator if the filesystem is subsequently grown to a
sufficient size.  Today that does not happen.

This patch consolidates xfs_set_inode32 and xfs_set_inode64 into a
single new function, and moves the "is the maximum inode number big
enough to matter" test into that function, so it doesn't rely on the
caller to get it right - which remount did not do, previously.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_mount.c
fs/xfs/xfs_mount.h
fs/xfs/xfs_super.c
fs/xfs/xfs_super.h