uprobes: Kill UTASK_BP_HIT state
authorOleg Nesterov <oleg@redhat.com>
Fri, 14 Sep 2012 16:52:10 +0000 (18:52 +0200)
committerOleg Nesterov <oleg@redhat.com>
Sat, 29 Sep 2012 19:21:53 +0000 (21:21 +0200)
commit1b08e907211cdc744f54871736005d9f3e7f182c
treedf62046438501ecd89e0bac1fb9b73edaf622e15
parent0578a97098dab967ece4b025fe5eb4984c4c86c0
uprobes: Kill UTASK_BP_HIT state

Kill UTASK_BP_HIT state, it buys nothing but complicates the code.
It is only used in uprobe_notify_resume() to decide who should be
called, we can check utask->active_uprobe != NULL instead. And this
allows us to simplify handle_swbp(), no need to clear utask->state.

Likewise we could kill UTASK_SSTEP, but UTASK_BP_HIT is worse and
imho should die. The problem is, it creates the special case when
task->utask is NULL, we can't distinguish RUNNING and BP_HIT. With
this patch utask == NULL always means RUNNING.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
include/linux/uprobes.h
kernel/events/uprobes.c